make RegisterSerializer generic #4422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCropp
requested review from
MarcoRossignoli and
Evangelink
as code owners
Evangelink
reviewed
Dec 21, 2024
|
yeah it just makes the usage a little more succinct |
jnyrup
reviewed
Dec 26, 2024
| { | ||
| _typeSerializer.Add(type, namedPipeSerializer); | ||
| INamedPipeSerializer namedPipeSerializer = new TSerializer(); |
There was a problem hiding this comment.
A minor difference here is that Activator.CreateInstance is now used to construct namedPipeSerializer.
Evangelink
requested changes
Jan 13, 2025
There was a problem hiding this comment.
@SimonCropp I have discussed it with the team and we will stick with current approach. Activator.CreateInstance should work with NAOT and trimming but we don't know if there are cases where it would be different. We don't yet have automatized enough tests around NAOT and trimming and we know current approach does work on all manual tests we did.
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is purely cosmetic. so feel free to burn it if u dont like it