Let folks disable OSC 52 #18449
Merged
Let folks disable OSC 52 #18449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is it worth to have a group policy? |
At this point, probably not. In the future if we ever add support for VT applications reading the clipboard (off by default,) we could have a policy that disallows users from enabling it. |
|
The test agents are currently pushing up daisies, so that's that then. |
carlos-zamora
requested changes
Jan 23, 2025
Comment on lines
74
to
81
| <!-- Allow VT Clipboard Writing --> | ||
| <local:SettingContainer x:Uid="Profile_AllowVtClipboardWrite" | ||
| ClearSettingValue="{x:Bind Profile.ClearAllowVtClipboardWrite}" | ||
| HasSettingValue="{x:Bind Profile.HasAllowVtClipboardWrite, Mode=OneWay}" | ||
| SettingOverrideSource="{x:Bind Profile.AllowVtClipboardWriteOverrideSource, Mode=OneWay}"> | ||
| <ToggleSwitch IsOn="{x:Bind Profile.AllowVtClipboardWrite, Mode=TwoWay}" | ||
| Style="{StaticResource ToggleSwitchInExpanderStyle}" /> | ||
| </local:SettingContainer> |
There was a problem hiding this comment.
nit: I think the page would look nicer if this was below "Allow VT Checksum Report"
microsoft-github-policy-service
bot
added
Needs-Author-Feedback
lhecker
approved these changes
Jan 23, 2025
Co-authored-by: Carlos Zamora <[email protected]>
carlos-zamora
approved these changes
Jan 23, 2025
…icrosoft/terminal into dev/duhowett/osc-not-52-that-sfor-sure
|
@carlos-zamora alas, reapproval is required |
carlos-zamora
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new profile setting,
compatibility.allowOSC52, which defaults totrue. When disabled, it will not allow applications to write to the clipboard.Security-minded folks may choose to disable it.