-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass foreground rights to the emperor #18325
Conversation
(Very annoying issue in the current Canary, so I'm hoping for a quick merge today.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh does it work?
At least my 2 test cases do work: Minimizing WT explicitly and then either launch from the start menu or via the explorer context menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ggez
Mind testing wtd.exe (since it uses CreateProcess!) and handoff? One thing to note - and this may explain why we have never had good luck testing these things - is that when a debugger is attached a process gets some special "allowed to take foreground" permissions. So make sure you test with no debugger! |
Everything's tested, PR description is updated. |
Forgetti di spaghetti in #18215.
Closes #18324
Validation Steps Performed