[rush] Fixed the issue where the lockfile object has an nullish value causing yaml.dump to report an error #5056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5053
After I set the preventManualShrinkwrapChanges field in the pnpm-config.json file to true, I successfully reproduced this problem.
Details
The following code logic will result in the lockfile object having nullish value, so the
yamlModule.safeDump
method will throw an exception.rushstack/libraries/rush-lib/src/logic/pnpm/PnpmShrinkWrapFileConverters.ts
Lines 51 to 64 in 724aa51
How it was tested
I have added some unit tests to ensure that the importers field in the lockfile will not contain nullish values.