[eslint-bulk] Fix caching during eslintrc lookup (#5065)

Co-authored-by: David Michon <[email protected]>
microsoft · Jan 7, 2025 · 4cf55de · 4cf55de
1 parent b2465b0
commit 4cf55de
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/common/changes/@rushstack/eslint-patch/eslint-cache-bug_2025-01-07-00-34.json b/common/changes/@rushstack/eslint-patch/eslint-cache-bug_2025-01-07-00-34.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/eslint-patch",
+      "comment": "Fix a performance issue when locating \".eslint-bulk-suppressions.json\".",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@rushstack/eslint-patch"
+}
diff --git a/eslint/eslint-patch/src/eslint-bulk-suppressions/bulk-suppressions-patch.ts b/eslint/eslint-patch/src/eslint-bulk-suppressions/bulk-suppressions-patch.ts
@@ -110,7 +110,9 @@ function findEslintrcFolderPathForNormalizedFileAbsolutePath(normalizedFilePath:
   ) {
     const cachedEslintrcFolderPath: string | undefined = eslintrcPathByFileOrFolderPath.get(currentFolder);
     if (cachedEslintrcFolderPath) {
-      return cachedEslintrcFolderPath;
+      // Need to cache this result into the intermediate paths
+      eslintrcFolderPath = cachedEslintrcFolderPath;
+      break;
     }
 
     pathsToCache.push(currentFolder);