Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI notebook text and vision tests #2597

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

imatiach-msft
Copy link
Contributor

Description

Fix CI notebook text and vision tests
Copilot summary:
This pull request includes several updates to the CI workflows and a minor update to the development requirements. The most important changes are the removal of Python 3.8 from the test matrix and the addition of specific conditions for uploading artifacts.

Updates to CI workflows:

Update to development requirements:

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.18%. Comparing base (283ee27) to head (7485001).

❗ There is a different number of reports uploaded between BASE (283ee27) and HEAD (7485001). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (283ee27) HEAD (7485001)
unittests 5 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2597       +/-   ##
===========================================
- Coverage   87.84%   70.18%   -17.66%     
===========================================
  Files         113       18       -95     
  Lines        6657     1278     -5379     
===========================================
- Hits         5848      897     -4951     
+ Misses        809      381      -428     
Flag Coverage Δ
unittests 70.18% <ø> (-17.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-text-vis-gates branch 4 times, most recently from 56fa936 to 123fceb Compare January 29, 2025 19:39
@imatiach-msft imatiach-msft force-pushed the ilmat/fix-text-vis-gates branch from 123fceb to 7485001 Compare January 29, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants