fix duplicate categorical features added from image exif metadata in RAI Vision Dashboard #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
force-pushed
the
ilmat/fix-duplicate-vision-categorical-features
branch
3 times, most recently
from
3e45d84 to
91651b8
Compare
…RAI Vision Dashboard
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2483 +/- ##
==========================================
- Coverage 88.83% 81.06% -7.78%
==========================================
Files 134 26 -108
Lines 7731 2318 -5413
==========================================
- Hits 6868 1879 -4989
+ Misses 863 439 -424
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2 similar comments
Advitya17
approved these changes
Jan 5, 2024
imatiach-msft
deleted the
ilmat/fix-duplicate-vision-categorical-features
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix duplicate categorical features added from image exif metadata in RAI Vision Dashboard
Seeing duplicate categorical features in RAI VIsion Dashboard:
It looks like we are adding them for every row but we should only add them once. Interestingly, this does not cause any errors currently as we are just checking if some feature name is in the list of categorical features in code, but it's definitely not desirable and can slow performance for larger image data.
This PR only adds the categorical feature names once to the list during exif feature metadata extraction and adds a test to validate this.
Checklist