Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release tensorflow pin in RAI vision and text package tests which was added last year to fix huggingface transformer models #2472

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Dec 27, 2023

Description

release tensorflow pin in RAI vision and text package tests which was added last year to fix huggingface transformer models

Last year we added a pin to the test cases to tensorflow<2.11.0 because the responsibleai-text package build was failing due to latest tensorflow breaking latest huggingface transformers package. Reverting this change back now that huggingface has caught up to ensure we are testing on the latest version of tensorflow in our unit tests.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be00e9a) 89.00% compared to head (2da6c44) 80.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2472      +/-   ##
==========================================
- Coverage   89.00%   80.48%   -8.53%     
==========================================
  Files         134       26     -108     
  Lines        7731     2316    -5415     
==========================================
- Hits         6881     1864    -5017     
+ Misses        850      452     -398     
Flag Coverage Δ
unittests 80.48% <ø> (-8.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imatiach-msft imatiach-msft force-pushed the ilmat/release-tf-pin-tests branch from 8da2e00 to b940dde Compare December 29, 2023 16:40
@imatiach-msft imatiach-msft force-pushed the ilmat/release-tf-pin-tests branch from b940dde to 2da6c44 Compare January 2, 2024 16:49
… added last year to fix huggingface transformer models
@imatiach-msft imatiach-msft merged commit 120f918 into main Jan 3, 2024
105 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/release-tf-pin-tests branch January 3, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants