-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apple): support disabling metal validation #2373
Conversation
@wcandillon FYI |
this is very cool 😎 |
Not obvious to me: Not every key in the app.json seems tested. Should I add some sort of test, or leave it as is? |
Oh, another note. Using REXML removes the newlines from the xcscheme so the structure of the file is different, but it's still usable by Xcode. Just thought I'd make sure to mention that. |
I would really appreciate it if you added tests. |
Co-authored-by: Tommy Nguyen <[email protected]>
Co-authored-by: Tommy Nguyen <[email protected]>
Co-authored-by: Tommy Nguyen <[email protected]>
I looked around the repo and I'm not sure I am coming up with a good test.. mostly because to practically test you need "pod install" to run, and/or a screenshot of Xcode with the scheme open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Verified that enableGPUValidationMode='1'
gets written
Thanks for adding this feature ❤️
Description
A couple of repositories (react-native-webgpu, @shopfiy/react-native-skia) need to have Metal Validation turned off for their libraries to run (and be tested in CI. Let's add a way to enable/disable that from the manifest.
Note:
enableGpuValidationMode = "1"
is in the xcscheme, that actually means that Metal API Validation is off. To turn it back on, you can't set it to "0", you have to remove the line. 🤷♂️Platforms affected
Test plan
Added and removed the key from the example apps' App.json, re-ran
pod install
and verified that Metal API Validation would flip.