-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds task 1.13 to Superposition Kata #1382
Conversation
Let me know when this is ready for review! |
Co-authored-by: James Kingdon <[email protected]>
Co-authored-by: James Kingdon <[email protected]>
Thank you @jkingdon-ms for the helpful feedback, @tcNickolas tagging you as it is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has quite a few build errors that CI build doesn't catch because this kata is not added to the katas/content/index.json file. We usually add this kata to the index when we work on it, so that it shows up in local tests and playground for us to play with and the CI build can verify it, and then in the very last iteration remove it so that it doesn't get published prematurely.
Thank you!
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
The CI build still fails. Did you try to build the new task locally in the playground? This helps to figure our build issues a lot |
Hi Mariia, I've pushed a few more changes now which hopefully address the remaining comments, let me know if anything needs tweaking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, only few minor edits!
Thank you!
Part of #1185