Skip to content

Commit

Permalink
Fix error reporting in vscode integration tests (#1105)
Browse files Browse the repository at this point in the history
I accidentally broke VS Code integration test error reporting with
#1015. `run()` should raise an error if any tests fail, but it was
swallowing the error after writing to console.

This made it so that CI would succeed even when tests failed. I did
manually look through the last few days' runs and didn't see any actual
failures.
  • Loading branch information
minestarks authored Feb 2, 2024
1 parent 477e459 commit b506d09
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion vscode/test/suites/run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ export function runMochaTests(requireTestModules: () => void): Promise<void> {
console.error(
`[error] ${failures} vscode integration test(s) failed.`,
);
e(new Error(`${failures} vscode integration test(s) failed.`));
} else {
c();
}
c();
});
} catch (err) {
console.error(err);
Expand Down

0 comments on commit b506d09

Please sign in to comment.