Skip to content

Commit

Permalink
minor ux fixes for resource estimator (#1065)
Browse files Browse the repository at this point in the history
  • Loading branch information
ivanbasov authored Jan 23, 2024
1 parent b99a3ce commit 4da03f5
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
8 changes: 4 additions & 4 deletions npm/ux/estimatesOverview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const columnNames = [
"Physical qubits",
];

const initialColumns = [0, 1, 2, 3, 4, 10, 11, 12];
const initialColumns = [0, 2, 3, 10, 11, 12];

const xAxis: Axis = {
isTime: true,
Expand Down Expand Up @@ -89,7 +89,7 @@ function frontierEntryToPlotEntry(entry: FrontierEntry): PlotItem {
y: entry.physicalCounts.physicalQubits,
label:
entry.physicalCountsFormatted.runtime +
" " +
", physical qubits: " +
entry.physicalCountsFormatted.physicalQubits,
};
}
Expand All @@ -104,7 +104,7 @@ function reDataToRowScatter(data: ReData, color: string): ScatterSeries {
y: data.physicalCounts.physicalQubits,
label:
data.physicalCountsFormatted.runtime +
" " +
", physical qubits: " +
data.physicalCountsFormatted.physicalQubits,
},
],
Expand Down Expand Up @@ -222,7 +222,7 @@ export function EstimatesOverview(props: {
</details>
<details open>
<summary style="font-size: 1.5em; font-weight: bold; margin: 24px 8px;">
Qubit-time diagram
Space-time diagram
</summary>
<ScatterChart
xAxis={xAxis}
Expand Down
2 changes: 1 addition & 1 deletion npm/ux/generate_report_code.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"logicalQubit/logicalCyclesPerSecond": "numberFormatF64.format(result.physicalCounts.breakdown.clockFrequency)",
"logicalQubit/logicalCycleTime": "numberFormat.format(result.logicalQubit.logicalCycleTime)",
"logicalQubit/physicalQubits": "numberFormat.format(result.logicalQubit.physicalQubits)",
"physicalCounts/breakdown/algorithmicLogicalDepth": "numberFormat.format(result.physicalCountsFormatted.algorithmicLogicalDepth)",
"physicalCounts/breakdown/algorithmicLogicalDepth": "numberFormat.format(result.physicalCounts.breakdown.algorithmicLogicalDepth)",
"physicalCounts/breakdown/algorithmicLogicalQubits": "numberFormat.format(result.physicalCounts.breakdown.algorithmicLogicalQubits)",
"physicalCounts/breakdown/cliffordErrorRate": "result.physicalCounts.breakdown.cliffordErrorRate",
"physicalCounts/breakdown/logicalDepth": "numberFormat.format(result.physicalCounts.breakdown.logicalDepth)",
Expand Down
2 changes: 1 addition & 1 deletion npm/ux/output_data.md
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ This is the probability in which executing a single T gate may fail.

[//]: # "physicalCountsFormatted/logicalDepthFactor"

_Factor, the initial number of logical cycles is multiplied by_
_Factor the initial number of logical cycles is multiplied by_

This is the factor takes into account a potential overhead to the initial number of logical cycles.

Expand Down
6 changes: 3 additions & 3 deletions npm/ux/report.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function CreateReport(result: SingleEstimateResult): ReportData {
explanation: `This is a runtime estimate for the execution time of the algorithm. In general, the execution time corresponds to the duration of one logical cycle (${numberFormat.format(
result.logicalQubit.logicalCycleTime,
)} nanosecs) multiplied by the ${numberFormat.format(
result.physicalCountsFormatted.algorithmicLogicalDepth,
result.physicalCounts.breakdown.algorithmicLogicalDepth,
)} logical cycles to run the algorithm. If however the duration of a single T factory (here: ${numberFormat.format(
result.tfactory == null ? 0 : result.tfactory.runtime,
)} nanosecs) is larger than the algorithm runtime, we extend the number of logical cycles artificially in order to exceed the runtime of a single T factory.`,
Expand Down Expand Up @@ -108,7 +108,7 @@ export function CreateReport(result: SingleEstimateResult): ReportData {
label: "Logical depth",
description: `Number of logical cycles performed`,
explanation: `This number is usually equal to the logical depth of the algorithm, which is ${numberFormat.format(
result.physicalCountsFormatted.algorithmicLogicalDepth,
result.physicalCounts.breakdown.algorithmicLogicalDepth,
)}. However, in the case in which a single T factory is slower than the execution time of the algorithm, we adjust the logical cycle depth to exceed the T factory's execution time.`,
});
entries.push({
Expand Down Expand Up @@ -553,7 +553,7 @@ export function CreateReport(result: SingleEstimateResult): ReportData {
entries.push({
path: "physicalCountsFormatted/logicalDepthFactor",
label: "Logical depth factor",
description: `Factor, the initial number of logical cycles is multiplied by`,
description: `Factor the initial number of logical cycles is multiplied by`,
explanation: `This is the factor takes into account a potential overhead to the initial number of logical cycles.`,
});
entries.push({
Expand Down
2 changes: 1 addition & 1 deletion npm/ux/scatterChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export function ScatterChart(props: {
const axisLineWidth = 1;
const xLeftMargin =
yAxisTitleWidth + yAxisTickCaptionMaxWidth + axisTickLength + axisLineWidth;
const xRightMargin = 100; // to show tooltips on the right hand side. If we can move tooltips dynamicslly, we can get rid of this.
const xRightMargin = 160; // to show tooltips on the right hand side. If we can move tooltips dynamically, we can get rid of this.

const axisTitleHeight = 20;
const xAxisTickCaptionMaxHeight = 16;
Expand Down
2 changes: 1 addition & 1 deletion resource_estimator/src/estimates/data/report.rs
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ impl Report {
});

let mut entries = vec![];
entries.push(ReportEntry::new("physicalCountsFormatted/logicalDepthFactor", "Logical depth factor", r#"Factor, the initial number of logical cycles is multiplied by"#, r#"This is the factor takes into account a potential overhead to the initial number of logical cycles."#));
entries.push(ReportEntry::new("physicalCountsFormatted/logicalDepthFactor", "Logical depth factor", r#"Factor the initial number of logical cycles is multiplied by"#, r#"This is the factor takes into account a potential overhead to the initial number of logical cycles."#));
entries.push(ReportEntry::new("physicalCountsFormatted/maxTFactories", "Maximum number of T factories", r#"The maximum number of T factories can be utilized during the algorithm's runtime"#, r#"This is the maximum number of T factories used for producing the demanded T states, which can be created and executed by the algorithm in parallel."#));
entries.push(ReportEntry::new("physicalCountsFormatted/maxDuration", "Maximum runtime duration", r#"The maximum runtime duration allowed for the algorithm runtime"#, r#"This is the maximum time allowed to the algorithm. If specified, the estimator targets to minimize the number of physical qubits consumed by the algorithm for runtimes under the maximum allowed."#));
entries.push(ReportEntry::new("physicalCountsFormatted/maxPhysicalQubits", "Maximum number of physical qubits", r#"The maximum number of physical qubits allowed for utilization to the algorith"#, r#"This is the maximum number of physical qubits available to the algorithm. If specified, the estimator targets to minimize the runtime of the algorithm with number of physical qubits consumed not exceeding this maximum."#));
Expand Down

0 comments on commit 4da03f5

Please sign in to comment.