Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(bidi): use fractional coordinates for pointerAction (#3… #34753

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Feb 12, 2025

…4675)"

Reverting this until Firefox implements support for fractional coordinates. Landing this now increases overall testing time on the bots and tips over the limit for Firefox Bidi tests.

This reverts commit 8e51be9.

Reference: #34742

…crosoft#34675)"

Reverting this until Firefox implements support for fractional coordinates. Landing this now increases overall testing time on the bots and tips over the limit for Firefox Bidi tests.

This reverts commit 8e51be9.
@yury-s yury-s requested a review from whimboo February 12, 2025 16:35
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make up your mind 😄

This comment has been minimized.

@yury-s yury-s merged commit 703ca9f into microsoft:main Feb 12, 2025
29 of 31 checks passed
@yury-s yury-s deleted the bidi-revert-fract-mouse branch February 12, 2025 17:00
Copy link
Contributor

Test results for "tests 1"

9 flaky ⚠️ [chromium-library] › tests/library/role-utils.spec.ts:442:5 › svg role=presentation @chromium-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @ubuntu-20.04-chromium-tip-of-tree
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:247:1 › should render network bars @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/expect-matcher-result.spec.ts:281:5 › toHaveScreenshot should populate matcherResult @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

38545 passed, 793 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants