Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webkit): roll to r2129 #34624

Closed
wants to merge 1 commit into from
Closed

Conversation

playwrightmachine
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test results for "tests others"

21600 passed, 505 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test results for "tests 1"

4 failed
❌ [playwright-test] › tests/playwright.ct-dev-server.spec.ts:21:5 › should run dev-server and use it for tests @macos-latest-node18-1
❌ [webkit-library] › tests/library/modernizr.spec.ts:34:3 › Safari Desktop @webkit-ubuntu-22.04-node18
❌ [webkit-library] › tests/library/modernizr.spec.ts:97:3 › Mobile Safari @webkit-ubuntu-22.04-node18
❌ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18

7 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:487:3 › should update extracted har.zip for page @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:247:1 › should render network bars @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

37774 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Test results for "tests 2"

1 fatal errors, not part of any test
15 failed
❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:482:5 › run-server › should not throw on close after disconnect @chrome-beta-macos-latest
❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:437:5 › run-server › should respect selectors @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest
❌ [chromium-library] › tests/library/signals.spec.ts:25:5 › should close the browser when the node process closes @chrome-macos-latest
❌ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-headed-windows-latest
❌ [firefox-library] › tests/library/video.spec.ts:187:5 › screencast › should capture static page @firefox-headed-windows-latest
❌ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:73:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest
❌ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:23:7 › should inspect locator @webkit-headed-windows-latest
❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge
❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
❌ [webkit-library] › tests/library/modernizr.spec.ts:34:3 › Safari Desktop @webkit-ubuntu-24.04
❌ [webkit-library] › tests/library/modernizr.spec.ts:97:3 › Mobile Safari @webkit-ubuntu-24.04
❌ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-24.04
❌ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-24.04

110 flaky ⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/global-fetch.spec.ts:357:3 › should not double stringify bool (false) body when content-type is application/json @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in nunit @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:159:5 › should connect to existing page with iframe and navigate @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chrome-beta-windows-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:580:5 › screencast › should capture static page in persistent context @smoke @chrome-beta-windows-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:482:5 › run-server › should not throw on close after disconnect @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-python.spec.ts:78:5 › should save the codegen output to a file if specified @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy @smoke @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:96:7 › cli codegen › should ignore programmatic events @chromium-headed-ubuntu-24.04
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @chromium-macos-13-large
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1298:1 › should pick locator in iframe @chromium-tip-of-tree-macos-13
⚠️ [chromium-page] › tests/page/page-mouse.spec.ts:244:3 › should tween mouse movement @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @chromium-windows-latest
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-beta-macos-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-20.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-1.spec.ts:993:7 › cli codegen › should clear when recording is disabled @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › tests/library/browsercontext-proxy.spec.ts:294:3 › should exclude patterns @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:132:3 › should not crash on showDirectoryPicker @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/download.spec.ts:435:5 › download event › should close the context without awaiting the download @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/inspector/console-api.spec.ts:45:3 › should support playwright.selector @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/inspector/console-api.spec.ts:50:3 › should support playwright.locator.value @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/inspector/console-api.spec.ts:56:3 › should support playwright.locator.values @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/inspector/console-api.spec.ts:67:3 › should support playwright.locator({ has }) @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/inspector/console-api.spec.ts:84:3 › should support locator.and() @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/inspector/console-api.spec.ts:89:3 › should support locator.or() @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/tracing.spec.ts:28:5 › should collect trace with resources, but no js @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/unroute-behavior.spec.ts:117:3 › page.close should not wait for active route handlers on the owning context @firefox-headed-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest
⚠️ [firefox-page] › tests/page/page-event-request.spec.ts:182:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-large
⚠️ [firefox-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @firefox-macos-13-large
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-13-xlarge
⚠️ [firefox-library] › tests/library/video.spec.ts:163:5 › screencast › should work with old options @firefox-macos-14-large
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-14-xlarge
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-20.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:43:5 › launch server › should work with wsPath @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:159:5 › should connect to existing page with iframe and navigate @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/chromium/launcher.spec.ts:28:3 › should not throw with remote-debugging-port argument @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/debug-controller.spec.ts:72:1 › should pick element @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click @msedge-beta-windows-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:24:7 › cli codegen › should contain open page @msedge-beta-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:107:3 › should accept objects as options @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/client-certificates.spec.ts:787:5 › browser › persistentContext › should pass with matching certificates @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @msedge-dev-ubuntu-20.04
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:454:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:99:5 › should generate routeFromHAR with --save-har @msedge-macos-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:580:5 › screencast › should capture static page in persistent context @smoke @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @tracing-webkit
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:610:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-page] › tests/page/wheel.spec.ts:166:3 › should set the modifiers @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:381:7 › cli codegen › should press @webkit-headed-ubuntu-20.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:96:7 › cli codegen › should ignore programmatic events @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:488:7 › cli codegen › should generate getByTestId @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:461:7 › cli codegen › should record ArrowDown @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:473:7 › cli codegen › should fill tricky characters @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:23:7 › should inspect locator @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:237:7 › cli codegen › should not target selector preview by text regexp @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:993:7 › cli codegen › should clear when recording is disabled @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:473:7 › cli codegen › should fill tricky characters @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:607:7 › cli codegen › should generate getByLabel without regex @webkit-headed-windows-latest
⚠️ [webkit-page] › tests/page/page-click.spec.ts:261:3 › should click on checkbox input and toggle @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:219:14 › element screenshot › element screenshot should work with device scale factor @webkit-ubuntu-20.04
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-24.04

258553 passed, 9958 skipped
✔️✔️✔️

Merge workflow run.

@yury-s
Copy link
Member

yury-s commented Feb 5, 2025

Closing in favor of #34631 that has Modernizr fix.

@yury-s yury-s closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants