[WebGPU] Support PIX Capture for WebGPU EP #23192
Conversation
|
@microsoft-github-policy-service agree [company="Microsoft"] |
|
@microsoft-github-policy-service agree |
shaoboyan091
changed the title
|
@fs-eire Please take another look, thanks! |
There was a problem hiding this comment.
Copilot reviewed 1 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (8)
- cmake/CMakeLists.txt: Language not supported
- cmake/external/onnxruntime_external_deps.cmake: Language not supported
- onnxruntime/core/providers/webgpu/webgpu_context.cc: Language not supported
- onnxruntime/core/providers/webgpu/webgpu_context.h: Language not supported
- onnxruntime/core/providers/webgpu/webgpu_execution_provider.cc: Language not supported
- onnxruntime/core/providers/webgpu/webgpu_execution_provider.h: Language not supported
- onnxruntime/core/providers/webgpu/webgpu_provider_factory.cc: Language not supported
- onnxruntime/core/providers/webgpu/webgpu_provider_options.h: Language not supported
|
lint is not happy |
|
@guschmue Ok, I thought it was bots error when I see |
|
Turns out the lintrunner doesn't work correctly because it cannot find clang-format.exe(Maybe due to I have a depot_tools? The error message seems related). However, after I fixed it locally, the lintrunner works. |
|
@fs-eire PTAL again, thanks! |
|
@fs-eire PTAL again, thanks! |
|
Thanks for reviewing! |
|
/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline |
|
/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline |
|
/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline,CoreML CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline |
|
Azure Pipelines successfully started running 7 pipeline(s). |
|
Azure Pipelines successfully started running 8 pipeline(s). |
|
Azure Pipelines successfully started running 10 pipeline(s). |
PIX Capture tool requires 'present' to end a frame capture. ORT doesn't have rendering work so no 'present' happens. To avoid endless waiting for PIX capture tool, this PR added a blank surface and 'present' on it in each session run. The surface is created in WebGPU ep constructor and closed in WebGPU ep destructor.
|
@fs-eire sry, using |
PIX Capture tool requires 'present' to end a frame capture. ORT doesn't have rendering work so no 'present' happens.
To avoid endless waiting for PIX capture tool, this PR added a blank surface and 'present' on it in each session run.
The surface is created in WebGPU ep constructor and closed in WebGPU ep destructor.
Description
Motivation and Context