-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Made response_type parameter configurable #53
base: MOODLE_400_STABLE
Are you sure you want to change the base?
[FEATURE] Made response_type parameter configurable #53
Conversation
@peterkeijsers please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Default value: 'code'. By making this configurable the flexibility of the plugin increases.
7d30d09
to
9fe9f64
Compare
Hi @peterkeijsers, Thank you for submitting the PR. We cannot merge this into release as is unfortunately for two main reasons:
On a side note, please keep version file increment minimal, i.e. only add 1 to the last two digits. The first 8 digits should match the counterpart of the the main Moodle version number. This is a rule made locally within the Microsoft plugins, and doesn't apply elsewhere. If you want, please feel free to convert your PR according to the suggestions above and submit a PR in the main repo. Note that any change made for Azure AD B2C needs to work for normal Azure AD too, as most of users don't have B2C. On receiving the PR, we will arrange testing and once passed, it will be included in the next release. Alternatively you can submit a feature request (as an issue) in the main repo, and it will be processed accordingly. Regards, |
I hade trouble connecting to Azure Active Rirectory B2C. That required changing the response_type from "code" to "code id_token token". By making this parameter configurable, the flexibility of the plugin increases.