Skip HVSock_* flaky tests until they are fixed #2365
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jie Chen <[email protected]>
katiewasnothere
approved these changes
Jan 28, 2025
helsaawy
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
t.Skipstatements to flaky tests in thetest/functional/hvsock_test.gofile.This allows github CI to pass by temporarily skipping them until they can be fixed. The tests are flaky in the sense that several sub test cases would pass in a run but fail in a different run. Internal CI shows the same behavior.
The investigation of the flaky tests is already in progress.
The re-enabling of the skipped tests is added to the backlog as well.
The following flaky tests are skipped:
test/functional/hvsock_test.go/TestHVSock_UVM_HostBindtest/functional/hvsock_test.go/TestHVSock_UVM_GuestBindtest/functional/hvsock_test.go/TestHVSock_Container_HostBindtest/functional/hvsock_test.go/TestHVSock_Container_GuestBind