Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support udt for rows.ColumnTypes #214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: support udt for rows.ColumnTypes #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions queries_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1682,6 +1682,7 @@ func TestColumnTypeIntrospection(t *testing.T) {
{"cast('abc' as char(3))", "CHAR", reflect.TypeOf(""), true, 3, false, 0, 0},
{"cast(N'abc' as nchar(3))", "NCHAR", reflect.TypeOf(""), true, 3, false, 0, 0},
{"cast(1 as sql_variant)", "SQL_VARIANT", reflect.TypeOf(nil), false, 0, false, 0, 0},
{"geometry::STGeomFromText('LINESTRING (100 100, 20 180, 180 180)', 0)", "geometry", reflect.TypeOf([]byte{}), true, 2147483647, false, 0, 0},
}
conn, logger := open(t)
defer conn.Close()
Expand Down
14 changes: 11 additions & 3 deletions types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ type typeInfo struct {
// Common Language Runtime (CLR) Instances
// http://msdn.microsoft.com/en-us/library/dd357962.aspx
type udtInfo struct {
//MaxByteSize uint32
// MaxByteSize uint32
DBName string
SchemaName string
TypeName string
Expand Down Expand Up @@ -535,7 +535,7 @@ func readLongLenType(ti *typeInfo, r *tdsBuffer, c *cryptoMetadata) interface{}
panic("shoulnd't get here")
}
func writeLongLenType(w io.Writer, ti typeInfo, buf []byte) (err error) {
//textptr
// textptr
err = binary.Write(w, binary.LittleEndian, byte(0x10))
if err != nil {
return
Expand All @@ -548,7 +548,7 @@ func writeLongLenType(w io.Writer, ti typeInfo, buf []byte) (err error) {
if err != nil {
return
}
//timestamp?
// timestamp?
err = binary.Write(w, binary.LittleEndian, uint64(0xFFFFFFFFFFFFFFFF))
if err != nil {
return
Expand Down Expand Up @@ -1137,6 +1137,8 @@ func makeGoLangScanType(ti typeInfo) reflect.Type {
return reflect.TypeOf([]byte{})
case typeVariant:
return reflect.TypeOf(nil)
case typeUdt:
return reflect.TypeOf([]byte{})
default:
panic(fmt.Sprintf("not implemented makeGoLangScanType for type %d", ti.TypeId))
}
Expand Down Expand Up @@ -1366,6 +1368,8 @@ func makeGoLangTypeName(ti typeInfo) string {
return "SQL_VARIANT"
case typeBigBinary:
return "BINARY"
case typeUdt:
return ti.UdtInfo.TypeName
default:
panic(fmt.Sprintf("not implemented makeGoLangTypeName for type %d", ti.TypeId))
}
Expand Down Expand Up @@ -1490,6 +1494,8 @@ func makeGoLangTypeLength(ti typeInfo) (int64, bool) {
return 0, false
case typeBigBinary:
return int64(ti.Size), true
case typeUdt:
return 2147483647, true
default:
panic(fmt.Sprintf("not implemented makeGoLangTypeLength for type %d", ti.TypeId))
}
Expand Down Expand Up @@ -1602,6 +1608,8 @@ func makeGoLangTypePrecisionScale(ti typeInfo) (int64, int64, bool) {
return 0, 0, false
case typeBigBinary:
return 0, 0, false
case typeUdt:
return 0, 0, false
default:
panic(fmt.Sprintf("not implemented makeGoLangTypePrecisionScale for type %d", ti.TypeId))
}
Expand Down