Using connection mode from Cosmos Configuration #4807
Merged
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajithaalurims
added
the
Azure API for FHIR
brendankowitz
approved these changes
Jan 29, 2025
|
Looks good - we should monitor latency with this change as it adds an extra hop since requests go through the gateway. |
rbans96
reviewed
Jan 29, 2025
| @@ -131,8 +131,16 @@ private CosmosClient CreateCosmosClientInternal(CosmosDataStoreConfiguration con | |||
| new CosmosClientBuilder(host, _cosmosAccessTokenProviderFactory.Invoke().TokenCredential) : | |||
| new CosmosClientBuilder(host, key); | |||
|
|
|||
| if (configuration.ConnectionMode == ConnectionMode.Gateway) | |||
There was a problem hiding this comment.
Should we add a logging statement to ensure that connectionMode is correctly populated from our config? If there are other means to confirm that, feel free to ignore
There was a problem hiding this comment.
In case of exceptions, we do see client configuration which displays connection mode.
Example: "ConnectionMode":"Direct"
To save time of PR build, I am going to leave it as it is.
rajithaalurims
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default connection mode in Cosmos Configuration is "Direct". This PR has changes to use connection mode based on the value in configuration file.
Related issues
Addresses [issue # 140094].
Testing
Confirmed that the connection mode is set based on the configuration file.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)