Fix SQL roundtrip issue for history event IDs (#201)

microsoft · Dec 18, 2023 · 63727fe · 63727fe
1 parent ceddafa
commit 63727fe
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/DurableTask.SqlServer/SqlUtils.cs b/src/DurableTask.SqlServer/SqlUtils.cs
@@ -134,7 +134,7 @@ public static HistoryEvent GetHistoryEvent(this DbDataReader reader, bool isOrch
                     historyEvent = new OrchestratorStartedEvent(eventId);
                     break;
                 case EventType.SubOrchestrationInstanceCompleted:
-                    historyEvent = new SubOrchestrationInstanceCompletedEvent(eventId, GetTaskId(reader), GetPayloadText(reader));
+                    historyEvent = new SubOrchestrationInstanceCompletedEvent(eventId: -1, GetTaskId(reader), GetPayloadText(reader));
                     break;
                 case EventType.SubOrchestrationInstanceCreated:
                     historyEvent = new SubOrchestrationInstanceCreatedEvent(eventId)
@@ -156,15 +156,15 @@ public static HistoryEvent GetHistoryEvent(this DbDataReader reader, bool isOrch
                     }
 
                     historyEvent = new SubOrchestrationInstanceFailedEvent(
-                        eventId,
+                        eventId: -1,
                         taskScheduledId: GetTaskId(reader),
                         reason: subOrchFailedReason,
                         details: subOrchFailedDetails,
                         failureDetails: subOrchFailureDetails);
                     break;
                 case EventType.TaskCompleted:
                     historyEvent = new TaskCompletedEvent(
-                        eventId,
+                        eventId: -1,
                         taskScheduledId: GetTaskId(reader),
                         result: GetPayloadText(reader));
                     break;
@@ -179,7 +179,7 @@ public static HistoryEvent GetHistoryEvent(this DbDataReader reader, bool isOrch
                     }
 
                     historyEvent = new TaskFailedEvent(
-                        eventId,
+                        eventId: -1,
                         taskScheduledId: GetTaskId(reader),
                         reason: taskFailedReason,
                         details: taskFailedDetails,
@@ -201,7 +201,7 @@ public static HistoryEvent GetHistoryEvent(this DbDataReader reader, bool isOrch
                     };
                     break;
                 case EventType.TimerFired:
-                    historyEvent = new TimerFiredEvent(eventId)
+                    historyEvent = new TimerFiredEvent(eventId: -1)
                     {
                         FireAt = GetVisibleTime(reader),
                         TimerId = GetTaskId(reader),