Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the theme resource link #1716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MGGSK
Copy link
Contributor

@MGGSK MGGSK commented Jan 6, 2025

Fixed the "WinUI Theme Resources (Github)" being broken.

Description

Changed the link in "ControlInfoData.json" from "https://github.com/microsoft/microsoft-ui-xaml/blob/winui3/release/X.Y-stable/controls/dev/CommonStyles/Common_themeresources_any.xaml" to "https://github.com/microsoft/microsoft-ui-xaml/blob/winui3/release/X.Y-stable/src/controls/dev/CommonStyles/Common_themeresources_any.xaml"

Motivation and Context

Fixes #1712

How Has This Been Tested?

Manual

Screenshots:

image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@karkarl
Copy link
Collaborator

karkarl commented Jan 7, 2025

/azp run

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Jan 8, 2025

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Jan 8, 2025

Also, there are two of these identical URIs.
Also, while you're updating this file, wild you like to remove the en-us/ localizers bits in some (5) of the URIs too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WinUI Themes Resources (GitHub) link in the WinUI 3 Gallery is broken
3 participants