Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved SystemBackdrop sample #1698

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Improved SystemBackdrop sample #1698

wants to merge 20 commits into from

Conversation

MGGSK
Copy link
Contributor

@MGGSK MGGSK commented Dec 12, 2024 •
edited
Loading

Made the sample easier to use.

Description

  1. Changed the sample description
  2. Added inheritance to the sample page
  3. Added a title bar to the sample window
  4. The sample window now has a icon
  5. The theme of the sample window can now be changed.
  6. The sample windows now have a list of backdrops that can be applied. If the user clicks opens the "MicaController" sample and clicks "Change Backdrop" the window won't apply Acrylic.
  7. Fixed the xaml sample code having c# comments.

Motivation and Context

The old sample has no info about how the materials look like.

How Has This Been Tested?

Manual

Screenshots:

image
image
image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@MGGSK MGGSK marked this pull request as ready for review December 23, 2024 20:32
marcelwgn
marcelwgn requested changes Jan 12, 2025
View reviewed changes
WinUIGallery/DataModel/ControlInfoData.json Outdated Show resolved Hide resolved
WinUIGallery/DataModel/ControlInfoData.json Outdated Show resolved Hide resolved
WinUIGallery/DataModel/ControlInfoData.json Outdated Show resolved Hide resolved
WinUIGallery/SamplePages/SampleBuiltInSystemBackdropsWindow.xaml.cs Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/SystemBackdropsPage.xaml Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/SystemBackdropsPage.xaml Show resolved Hide resolved
@niels9001
Copy link
Contributor

Would it make sense to change this Button into a ComboBox?

image

We can also do this in a seperate PR!

@niels9001
Copy link
Contributor

See a bunch of UX nits in my comments.

The textblock is redundant if we use a ComboBox right? We can set the selected backdrop there, and increase the spacing between the 2 comboboxes a bit:

image

@MGGSK
Copy link
Contributor Author

MGGSK commented Jan 13, 2025

See a bunch of UX nits in my comments.

The textblock is redundant if we use a ComboBox right? We can set the selected backdrop there, and increase the spacing between the 2 comboboxes a bit:

image

I changed the spacing from 12 to 20 px.

niels9001
niels9001 requested changes Jan 14, 2025
View reviewed changes
WinUIGallery/ControlPages/SystemBackdropsPage.xaml Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/SystemBackdropsPage.xaml Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/SystemBackdropsPage.xaml Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/SystemBackdropsPage.xaml Outdated Show resolved Hide resolved
@niels9001
Copy link
Contributor

/azp run

1 similar comment
@marcelwgn
Copy link
Contributor

/azp run

@karkarl
Copy link
Collaborator

karkarl commented Jan 15, 2025

/azp run

1 similar comment
@karkarl
Copy link
Collaborator

karkarl commented Jan 15, 2025

/azp run

niels9001
niels9001 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

marcelwgn
marcelwgn reviewed Jan 22, 2025
View reviewed changes
WinUIGallery/ControlPages/SystemBackdropsPage.xaml Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/SystemBackdropsPage.xaml Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/SystemBackdropsPage.xaml Outdated
<StackPanel>
<TextBlock TextWrapping="WrapWholeWords">
Manages rendering and system policy for the background acrylic material. Acrylic has the same level of customization as Mica, but the type (Base / Thin) can't be changed using the DesktopAcrylicBackdrop class.
If you wan't to use Acrylic Thin in your app you have to use the DesktopAcrylicController class. There are 2 types of Acrylic: Base and Thin. The DesktopAcrylicBackdrop class uses a version of the Base type with less dimming.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order of mentioning here: First mention there are two types, then explain how to use thin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order of mentioning here: First mention there are two types, then explain how to use thin?

Thanks for the suggestions.

WinUIGallery/ControlPages/SystemBackdropsPage.xaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwgn marcelwgn marcelwgn requested changes

@niels9001 niels9001 niels9001 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MGGSK @niels9001 @marcelwgn @karkarl