Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to .NET 9 #408

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull-request-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v3
with:
dotnet-version: 8.0.101
dotnet-version: 9.0.100

- name: Add permission to run shell
run: chmod -R +x *.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v3
with:
dotnet-version: 8.0.101
dotnet-version: 9.0.x

- name: Restore dependencies
run: ./build-restore.cmd
Expand Down
2 changes: 1 addition & 1 deletion .pipelines/azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ steps:
continueOnError: false
inputs:
packageType: 'sdk'
version: '8.0.101'
version: '9.0.x'
useGlobalJson: false
performMultiLevelLookup: true
workingDirectory: '$(Build.SourcesDirectory)'
Expand Down
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "8.0.101",
"version": "9.0.100",
"rollForward": "feature"
}
}
3 changes: 3 additions & 0 deletions src/VirtualClient/CodeQuality.targets
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,15 @@
<ItemGroup>
<PackageReference Include="AsyncFixer" Version="1.6.0">
<PrivateAssets>All</PrivateAssets>
<ExcludeAssets>runtime</ExcludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0">
<PrivateAssets>All</PrivateAssets>
<ExcludeAssets>runtime</ExcludeAssets>
</PackageReference>
<PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
<PrivateAssets>All</PrivateAssets>
<ExcludeAssets>runtime</ExcludeAssets>
</PackageReference>
</ItemGroup>
</Project>
Expand Down
48 changes: 14 additions & 34 deletions src/VirtualClient/Module.props
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
-->

<!-- AutoFixture -->
<AutoFixture_PackageVersion>4.17.0</AutoFixture_PackageVersion>
<AutoFixture_PackageVersion>4.18.1</AutoFixture_PackageVersion>

<!-- Azure.Identity -->
<Azure_Identity_PackageVersion>1.11.4</Azure_Identity_PackageVersion>
Expand All @@ -35,26 +35,8 @@
<!-- MathNet.Numerics.Signed -->
<MathNet_Numerics_Signed_PackageVersion>5.0.0</MathNet_Numerics_Signed_PackageVersion>

<!-- Microsoft.AspNetCore -->
<Microsoft_AspNetCore_PackageVersion>2.2.0</Microsoft_AspNetCore_PackageVersion>

<!-- Microsoft.AspNetCore.Authentication -->
<Microsoft_AspNetCore_Authentication_PackageVersion>2.2.0</Microsoft_AspNetCore_Authentication_PackageVersion>

<!-- Microsoft.AspNetCore.Hosting -->
<Microsoft_AspNetCore_Hosting_PackageVersion>2.2.7</Microsoft_AspNetCore_Hosting_PackageVersion>

<!-- Microsoft.AspNetCore.Mvc -->
<Microsoft_AspNetCore_Mvc_PackageVersion>2.2.0</Microsoft_AspNetCore_Mvc_PackageVersion>

<!-- Microsoft.AspNetCore.Mvc.Formatters.Json -->
<Microsoft_AspNetCore_Mvc_Formatters_Json_PackageVersion>2.2.0</Microsoft_AspNetCore_Mvc_Formatters_Json_PackageVersion>

<!-- Microsoft.AspNetCore.Mvc.Versioning -->
<Microsoft_AspNetCore_Mvc_Versioning_PackageVersion>5.1.0</Microsoft_AspNetCore_Mvc_Versioning_PackageVersion>

<!-- Microsoft.AspNetCore.Mvc.NewtonsoftJson -->
<Microsoft_AspNetCore_Mvc_NewtonsoftJson_PackageVersion>6.0.12</Microsoft_AspNetCore_Mvc_NewtonsoftJson_PackageVersion>
<Microsoft_AspNetCore_Mvc_NewtonsoftJson_PackageVersion>9.0.0</Microsoft_AspNetCore_Mvc_NewtonsoftJson_PackageVersion>

<!-- Microsoft.CodeAnalysis.Common -->
<Microsoft_CodeAnalysis_Common_PackageVersion>4.7.0</Microsoft_CodeAnalysis_Common_PackageVersion>
Expand All @@ -66,28 +48,28 @@
<Microsoft_Diagnostics_Tracing_TraceEvent_PackageVersion>2.0.61</Microsoft_Diagnostics_Tracing_TraceEvent_PackageVersion>

<!-- Microsoft.Extensions.Configuration -->
<Microsoft_Extensions_Configuration_PackageVersion>8.0.0</Microsoft_Extensions_Configuration_PackageVersion>
<Microsoft_Extensions_Configuration_PackageVersion>9.0.0</Microsoft_Extensions_Configuration_PackageVersion>

<!-- Microsoft.Extensions.Configuration.Json -->
<Microsoft_Extensions_Configuration_Json_PackageVersion>8.0.0</Microsoft_Extensions_Configuration_Json_PackageVersion>
<Microsoft_Extensions_Configuration_Json_PackageVersion>9.0.0</Microsoft_Extensions_Configuration_Json_PackageVersion>

<!-- Microsoft.Extensions.DependencyInjection -->
<Microsoft_Extensions_DependencyInjection_PackageVersion>8.0.0</Microsoft_Extensions_DependencyInjection_PackageVersion>
<Microsoft_Extensions_DependencyInjection_PackageVersion>9.0.0</Microsoft_Extensions_DependencyInjection_PackageVersion>

<!-- Microsoft.Extensions.Logging -->
<Microsoft_Extensions_Logging_PackageVersion>8.0.0</Microsoft_Extensions_Logging_PackageVersion>
<Microsoft_Extensions_Logging_PackageVersion>9.0.0</Microsoft_Extensions_Logging_PackageVersion>

<!-- Microsoft.Extensions.Logging.Console -->
<Microsoft_Extensions_Logging_Console_PackageVersion>8.0.0</Microsoft_Extensions_Logging_Console_PackageVersion>
<Microsoft_Extensions_Logging_Console_PackageVersion>9.0.0</Microsoft_Extensions_Logging_Console_PackageVersion>

<!-- Microsoft.NET.Test.Sdk -->
<Microsoft_NET_Test_Sdk_PackageVersion>17.0.0</Microsoft_NET_Test_Sdk_PackageVersion>
<Microsoft_NET_Test_Sdk_PackageVersion>17.11.1</Microsoft_NET_Test_Sdk_PackageVersion>

<!-- Microsoft.Extensions.Http.Polly -->
<Microsoft_Extensions_Http_Polly_PackageVersion>6.0.9</Microsoft_Extensions_Http_Polly_PackageVersion>
<Microsoft_Extensions_Http_Polly_PackageVersion>9.0.0</Microsoft_Extensions_Http_Polly_PackageVersion>

<!-- Microsoft.Windows.Compatibility -->
<Microsoft_Windows_Compatibility_PackageVersion>8.0.6</Microsoft_Windows_Compatibility_PackageVersion>
<Microsoft_Windows_Compatibility_PackageVersion>9.0.0</Microsoft_Windows_Compatibility_PackageVersion>

<!-- Microsoft.Win32.Registry -->
<Microsoft_Win32_Registry_PackageVersion>5.0.0</Microsoft_Win32_Registry_PackageVersion>
Expand All @@ -102,13 +84,10 @@
<NUnit_PackageVersion>3.13.2</NUnit_PackageVersion>

<!-- NUnit3TestAdapter -->
<NUnit3TestAdapter_PackageVersion>4.2.1</NUnit3TestAdapter_PackageVersion>
<NUnit3TestAdapter_PackageVersion>4.6.0</NUnit3TestAdapter_PackageVersion>

<!-- Polly -->
<Polly_PackageVersion>7.2.3</Polly_PackageVersion>

<!-- Polly.Extensions.Http -->
<Polly_Extensions_Http_PackageVersion>3.0.0</Polly_Extensions_Http_PackageVersion>
<Polly_PackageVersion>8.5.0</Polly_PackageVersion>

<!-- Serilog.Extensions.Logging -->
<Serilog_Extensions_Logging_PackageVersion>7.0.0</Serilog_Extensions_Logging_PackageVersion>
Expand Down Expand Up @@ -150,7 +129,7 @@
<System_Net_NameResolution_PackageVersion>4.3.0</System_Net_NameResolution_PackageVersion>

<!-- System.Reflection.Metadata -->
<System_Reflection_Metadata_PackageVersion>8.0.0</System_Reflection_Metadata_PackageVersion>
<System_Reflection_Metadata_PackageVersion>9.0.0</System_Reflection_Metadata_PackageVersion>

<!-- System.Security.Principal.Windows -->
<System_Security_Principal_Windows_PackageVersion>5.0.0</System_Security_Principal_Windows_PackageVersion>
Expand Down Expand Up @@ -180,6 +159,7 @@
<GenerateAssemblyInfo>true</GenerateAssemblyInfo>
<AssemblyVersion>1.0.0.0</AssemblyVersion>
<AssemblyVersion Condition="'$(VCBuildVersion)' != ''">$(VCBuildVersion)</AssemblyVersion>
<SatelliteResourceLanguages>en</SatelliteResourceLanguages>
</PropertyGroup>

<!--
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<IsPackable>false</IsPackable>
<RunCodeAnalysis>false</RunCodeAnalysis>
<RunAnalyzers>true</RunAnalyzers>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ public void Setup()
public void Compressor7zipResultsParserParsesTheExpectedSizesAndTimeFromResults()
{
this.testParser.Parse();
this.testParser.SizeAndTime.PrintDataTableFormatted();
Assert.AreEqual(4, this.testParser.SizeAndTime.Columns.Count);
Assert.AreEqual(7, this.testParser.SizeAndTime.Rows.Count);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@ public void Setup()
this.testParser.Parse();
}

[Test]
public void CoreMarkParserViewDataTable()
{
this.testParser.CoreMarkResult.PrintDataTableFormatted();
}

[Test]
public void CoreMarkParserVerifyMetricsSingleThread()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
/home/anyuser/vc/packages/aspnetbenchmarks/src/Benchmarks/Benchmarks.csproj : warning NU1604: Project dependency Microsoft.AspNetCore.Mvc.NewtonsoftJson does not contain an inclusive lower bound. Include a lower bound in the dependency version to ensure consistent restore results.
Restored /home/anyuser/vc/packages/aspnetbenchmarks/src/Benchmarks/Benchmarks.csproj (in 837 ms).
/home/anyuser/vc/packages/aspnetbenchmarks/src/Benchmarks/Benchmarks.csproj : warning NU1604: Project dependency Microsoft.AspNetCore.Mvc.NewtonsoftJson does not contain an inclusive lower bound. Include a lower bound in the dependency version to ensure consistent restore results.
Benchmarks -> /home/anyuser/vc/packages/aspnetbenchmarks/src/Benchmarks/bin/Release/net8.0/Benchmarks.dll
Benchmarks -> /home/anyuser/vc/packages/aspnetbenchmarks/src/Benchmarks/bin/Release/net9.0/Benchmarks.dll

Build succeeded.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ public void Setup()
[Test]
public void GeekBenchParserVerifySingleCoreResult()
{
this.testParser.SingleCoreResult.PrintDataTableFormatted();

Assert.AreEqual(5, this.testParser.SingleCoreResult.Columns.Count);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ public void Setup()
public void GzipResultsParserParsesTheExpectedSizesAndTimeFromResults()
{
this.testParser.Parse();
this.testParser.ReductionRatio.PrintDataTableFormatted();
Assert.AreEqual(4, this.testParser.ReductionRatio.Columns.Count);
Assert.AreEqual(12, this.testParser.ReductionRatio.Rows.Count);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,6 @@ public void LAPACKParserVerifyResults()
public void LAPACKParserVerifyMetrics()
{
IList<Metric> metrics = this.testParser.Parse();
this.testParser.LINSingleResult.PrintDataTableFormatted();
this.testParser.LINDoubleResult.PrintDataTableFormatted();
this.testParser.LINComplexResult.PrintDataTableFormatted();
this.testParser.LINComplexDoubleResult.PrintDataTableFormatted();
this.testParser.EIGSingleResult.PrintDataTableFormatted();
this.testParser.EIGDoubleResult.PrintDataTableFormatted();
this.testParser.EIGComplexResult.PrintDataTableFormatted();
this.testParser.EIGComplexDoubleResult.PrintDataTableFormatted();
MetricAssert.Exists(metrics, "compute_time_LIN_Single_Precision", 4.02, "seconds");
MetricAssert.Exists(metrics, "compute_time_LIN_Double_Precision", 4.11, "seconds");
MetricAssert.Exists(metrics, "compute_time_LIN_Complex", 10.5, "seconds");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ public void Setup()
public void OpenFOAMResultsParserParsesTheExpectedExecutionTimesFromResults()
{
this.testParser.Parse();
this.testParser.ExecutionTimes.PrintDataTableFormatted();
Assert.AreEqual(4, this.testParser.ExecutionTimes.Columns.Count);
Assert.AreEqual(313, this.testParser.ExecutionTimes.Rows.Count);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public void Pbzip2ResultsParserParsesTheExpectedSizesAndTimeFromResults(bool com
{
this.testParser = new Pbzip2MetricsParser(this.rawText, compression);
this.testParser.Parse();
this.testParser.SizeAndTime.PrintDataTableFormatted();
Assert.AreEqual(4, this.testParser.SizeAndTime.Columns.Count);
Assert.AreEqual(25, this.testParser.SizeAndTime.Rows.Count);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<IsPackable>false</IsPackable>
<RunCodeAnalysis>false</RunCodeAnalysis>
<RunAnalyzers>false</RunAnalyzers>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -207,13 +207,13 @@ protected async Task BuildAspNetBenchAsync(EventContext telemetryContext, Cancel
}

this.dotnetExePath = this.Combine(dotnetSdkPackage.Path, this.Platform == PlatformID.Unix ? "dotnet" : "dotnet.exe");
// ~/vc/packages/dotnet/dotnet build -c Release -p:BenchmarksTargetFramework=net8.0
// ~/vc/packages/dotnet/dotnet build -c Release -p:BenchmarksTargetFramework=net9.0
// Build the aspnetbenchmark project
string buildArgument = $"build -c Release -p:BenchmarksTargetFramework={this.TargetFramework}";
await this.ExecuteCommandAsync(this.dotnetExePath, buildArgument, this.aspnetBenchDirectory, telemetryContext, cancellationToken)
.ConfigureAwait(false);

// "C:\Users\vcvmadmin\Benchmarks\src\Benchmarks\bin\Release\net8.0\Benchmarks.dll"
// "C:\Users\vcvmadmin\Benchmarks\src\Benchmarks\bin\Release\net9.0\Benchmarks.dll"
this.aspnetBenchDllPath = this.Combine(
this.aspnetBenchDirectory,
"bin",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,13 +147,13 @@ await this.systemManagement.MakeFileExecutableAsync(this.bombardierFilePath, thi

this.dotnetExePath = this.Combine(dotnetSdkPackage.Path, this.Platform == PlatformID.Unix ? "dotnet" : "dotnet.exe");

// ~/vc/packages/dotnet/dotnet build -c Release -p:BenchmarksTargetFramework=net8.0
// ~/vc/packages/dotnet/dotnet build -c Release -p:BenchmarksTargetFramework=net9.0
// Build the aspnetbenchmark project
string buildArgument = $"build -c Release -p:BenchmarksTargetFramework={this.TargetFramework}";
await this.ExecuteCommandAsync(this.dotnetExePath, buildArgument, this.aspnetBenchDirectory, cancellationToken)
.ConfigureAwait(false);

// "C:\Users\vcvmadmin\Benchmarks\src\Benchmarks\bin\Release\net8.0\Benchmarks.dll"
// "C:\Users\vcvmadmin\Benchmarks\src\Benchmarks\bin\Release\net9.0\Benchmarks.dll"
this.aspnetBenchDllPath = this.Combine(
this.aspnetBenchDirectory,
"bin",
Expand Down
2 changes: 0 additions & 2 deletions src/VirtualClient/VirtualClient.Actions/FIO/FioExecutor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -834,8 +834,6 @@ protected virtual void CaptureMetrics(
this.GetMetricsParsingDirectives(out bool parseReadMetrics, out bool parseWriteMetrics, commandArguments);

string modifiedOutput = this.FilterWarnings(workloadProcess.StandardOutput.ToString());

Console.WriteLine("Modified output:\n" + modifiedOutput);
parser = new FioMetricsParser(modifiedOutput, parseReadMetrics, parseWriteMetrics);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -381,17 +381,13 @@ private async Task WaitForResultsAsync(TimeSpan timeout, EventContext telemetryC

while (DateTime.UtcNow < pollingTimeout && !cancellationToken.IsCancellationRequested)
{
Console.WriteLine(this.ResultsPath);

if (fileAccess.Exists(this.ResultsPath))
{
try
{
resultsContent = await this.SystemManager.FileSystem.File.ReadAllTextAsync(this.ResultsPath)
.ConfigureAwait(false);

// Console.WriteLine(resultsContent);

if (!string.IsNullOrWhiteSpace(resultsContent))
{
this.Logger.LogMessage($"{this.TypeName}.WorkloadOutputFileContents", telemetryContext
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ private static List<double> GetPacketsLatency(string preprocessedText)

if (headerCount == 0 && line.Trim() != Seperator)
{
Console.WriteLine(line);

throw new WorkloadResultsException(
"Results parsing operation failed. The Sockperf parser failed to parse the complete header.",
ErrorReason.WorkloadResultsNotFound);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<AssemblyName>VirtualClient.Actions</AssemblyName>
<NoWarn>SA1508;CA1416;CS4014;CA2213;IL2026</NoWarn>
</PropertyGroup>
Expand All @@ -10,7 +10,6 @@
<!-- Global package dependency versions are defined in the Module.props for the solution. -->
<PackageReference Include="MathNet.Numerics.Signed" Version="$(MathNet_Numerics_Signed_PackageVersion)" />
<PackageReference Include="Microsoft.Windows.Compatibility" Version="$(Microsoft_Windows_Compatibility_PackageVersion)" />
<PackageReference Include="Microsoft.Extensions.Http.Polly" Version="$(Microsoft_Extensions_Http_Polly_PackageVersion)" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<IsPackable>false</IsPackable>
<RunCodeAnalysis>false</RunCodeAnalysis>
<RunAnalyzers>false</RunAnalyzers>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ namespace VirtualClient.Api
using System;
using System.ComponentModel;
using System.Threading.Tasks;
using Asp.Versioning;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging;
Expand Down
1 change: 1 addition & 0 deletions src/VirtualClient/VirtualClient.Api/EventsController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ namespace VirtualClient.Api
using System.ComponentModel;
using System.Threading;
using System.Threading.Tasks;
using Asp.Versioning;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging;
Expand Down
10 changes: 4 additions & 6 deletions src/VirtualClient/VirtualClient.Api/VirtualClient.Api.csproj
Original file line number Diff line number Diff line change
@@ -1,19 +1,17 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<AssemblyName>VirtualClient.Api</AssemblyName>
<RootNamespace>VirtualClient.Api</RootNamespace>
<NoWarn>AD0001,SA1508</NoWarn>
</PropertyGroup>

<ItemGroup>
<!-- Global package dependency versions are defined in the Module.props for the solution. -->
<PackageReference Include="Microsoft.AspNetCore" Version="$(Microsoft_AspNetCore_PackageVersion)" />
<PackageReference Include="Microsoft.AspNetCore.Authentication" Version="$(Microsoft_AspNetCore_Authentication_PackageVersion)" />
<PackageReference Include="Microsoft.AspNetCore.Mvc" Version="$(Microsoft_AspNetCore_Mvc_PackageVersion)" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Formatters.Json" Version="$(Microsoft_AspNetCore_Mvc_Formatters_Json_PackageVersion)" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Versioning" Version="$(Microsoft_AspNetCore_Mvc_Versioning_PackageVersion)" />
<FrameworkReference Include="Microsoft.AspNetCore.App" />
<PackageReference Include="Asp.Versioning.Mvc" Version="8.1.0" />
<PackageReference Include="System.IO.FileSystem" Version="4.3.0" />
<PackageReference Include="System.Diagnostics.Debug" Version="$(System_Diagnostics_Debug_PackageVersion)" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="$(Microsoft_Extensions_DependencyInjection_PackageVersion)" />
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<IsPackable>false</IsPackable>
<RootNamespace>VirtualClient.Common</RootNamespace>
<NoWarn>CA1001</NoWarn>
Expand Down
Loading
Loading