-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarded AMD SMI for Linux and added more metrics #344
Draft
srividyaprasad
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
srividyaprasad:users/t-srprasad/OnboardAMDSMIMetricandXGMIforLinux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Onboarded AMD SMI for Linux and added more metrics #344
srividyaprasad
wants to merge
7
commits into
microsoft:main
from
srividyaprasad:users/t-srprasad/OnboardAMDSMIMetricandXGMIforLinux
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmalkapuram
reviewed
Jul 15, 2024
nmalkapuram
reviewed
Jul 15, 2024
src/VirtualClient/VirtualClient.Monitors/AmdSmiMetricQueryGpuParser.cs
Outdated
Show resolved
Hide resolved
nmalkapuram
reviewed
Jul 15, 2024
src/VirtualClient/VirtualClient.Monitors.UnitTests/AmdSmiMetricQueryGpuParserUnitTests.cs
Outdated
Show resolved
Hide resolved
yangpanMS
reviewed
Jul 15, 2024
yangpanMS
reviewed
Jul 15, 2024
yangpanMS
reviewed
Jul 15, 2024
src/VirtualClient/VirtualClient.Main/profiles/MONITORS-GPU-AMD-SMI.json
Outdated
Show resolved
Hide resolved
yangpanMS
reviewed
Jul 15, 2024
src/VirtualClient/VirtualClient.Monitors.UnitTests/Examples/amd-smi/result1.txt
Outdated
Show resolved
Hide resolved
yangpanMS
reviewed
Jul 15, 2024
@microsoft-github-policy-service agree company="Microsoft" |
…icandXGMIforLinux
yangpanMS
reviewed
Aug 14, 2024
src/VirtualClient/VirtualClient.Monitors.UnitTests/Examples/amd-smi/result.txt
Outdated
Show resolved
Hide resolved
…Us which runs on Linux and Windows. Updated documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support of AMD SMI monitoring tool for Linux.
Parsed additional metrics such as GPU and memory utilizations, temperatures, power drawn and various clocks from amd-smi metric.
Parsed and added bidirectional XGMI bandwidth calculations from amd-smi xgmi.