[IT NumberWithUnits] Fix for currency prefix dollari for Italian (#3069)

microsoft · Jan 30, 2023 · e7927a6 · e7927a6
1 parent 1d910cb
commit e7927a6
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 3 deletions.
diff --git a/.NET/Microsoft.Recognizers.Definitions.Common/Italian/NumbersWithUnitDefinitions.cs b/.NET/Microsoft.Recognizers.Definitions.Common/Italian/NumbersWithUnitDefinitions.cs
@@ -565,7 +565,7 @@ public static class NumbersWithUnitDefinitions
       public const string CompoundUnitConnectorRegex = @"(?<spacer>e)";
       public static readonly Dictionary<string, string> CurrencyPrefixList = new Dictionary<string, string>
         {
-            { @"Dollar", @"$" },
+            { @"Dollar", @"$|dollari" },
             { @"United States dollar", @"$ stati uniti|us$|us $|u.s. $|u.s $" },
             { @"East Caribbean dollar", @"east caribbean $" },
             { @"Australian dollar", @"$ australiano|$ australia" },

diff --git a/Patterns/Italian/Italian-NumbersWithUnit.yaml b/Patterns/Italian/Italian-NumbersWithUnit.yaml
@@ -643,7 +643,7 @@ CurrencyPrefixList: !dictionary
   types: [ string, string ]
   entries:
 #Dollar Prefix
-    Dollar: $
+    Dollar: $|dollari
     United States dollar: $ stati uniti|us$|us $|u.s. $|u.s $
     East Caribbean dollar: east caribbean $
     Australian dollar: $ australiano|$ australia

diff --git a/...zers-number-with-unit/recognizers_number_with_unit/resources/italian_numeric_with_unit.py b/...zers-number-with-unit/recognizers_number_with_unit/resources/italian_numeric_with_unit.py
@@ -541,7 +541,7 @@ class ItalianNumericWithUnit:
                                         ("Millibitcoin", "MILLIBITCOIN"),
                                         ("Satoshi", "SATOSHI")])
     CompoundUnitConnectorRegex = f'(?<spacer>e)'
-    CurrencyPrefixList = dict([("Dollar", "$"),
+    CurrencyPrefixList = dict([("Dollar", "$|dollari"),
                                ("United States dollar", "$ stati uniti|us$|us $|u.s. $|u.s $"),
                                ("East Caribbean dollar", "east caribbean $"),
                                ("Australian dollar", "$ australiano|$ australia"),

diff --git a/Specs/NumberWithUnit/Italian/CurrencyModel.json b/Specs/NumberWithUnit/Italian/CurrencyModel.json
@@ -1689,5 +1689,37 @@
         "End": 5
       }
     ]
+  },
+  {
+    "Input": "Ho bisogno di dollari 996",
+    "NotSupported": "javascript, java",
+    "Results": [
+      {
+        "Text": "dollari 996",
+        "TypeName": "currency",
+        "Resolution": {
+          "value": "996",
+          "unit": "Dollar"
+        },
+        "Start": 14,
+        "End": 24
+      }
+    ]
+  },
+  {
+    "Input": "dollari 4",
+    "NotSupported": "javascript, java",
+    "Results": [
+      {
+        "Text": "dollari 4",
+        "TypeName": "currency",
+        "Resolution": {
+          "value": "4",
+          "unit": "Dollar"
+        },
+        "Start": 0,
+        "End": 8
+      }
+    ]
   }
 ]