Skip to content

Commit

Permalink
Check that a parameter should be added before adding it
Browse files Browse the repository at this point in the history
  • Loading branch information
jenshnielsen committed Dec 16, 2024
1 parent 5f88270 commit 72d0be9
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/qcodes/instrument/instrument_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ def add_parameter(
if "bind_to_instrument" not in kwargs.keys():
kwargs["bind_to_instrument"] = True

bind_to_instrument = kwargs["bind_to_instrument"]

try:
param = parameter_class(name=name, instrument=self, **kwargs)
except TypeError:
Expand All @@ -180,7 +182,7 @@ def add_parameter(
param = parameter_class(name=name, instrument=self, **kwargs)

existing_parameter = self.parameters.get(name, None)
if not existing_parameter:
if not existing_parameter and bind_to_instrument:
warnings.warn(
f"Parameter {name} did not correctly register itself on instrument"
f" {self.name}. Please check that `instrument` argument is passed "
Expand Down

0 comments on commit 72d0be9

Please sign in to comment.