Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add layout to V3 schema #723

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Add layout to V3 schema #723

merged 2 commits into from
Sep 20, 2024

Conversation

swapnilbhalgat
Copy link
Contributor

Problem

For form controls, layout can be edited by makers to change the visual layout of the control. Hence, we need to serialize it with YAML schema

Solution

Add layout to V3 schema

Changes

Adds layout to V3 schema

joem-msft
joem-msft reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@joem-msft joem-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks all good to go. just run the src\schemas\publish.cmd.

src/schemas/pa-yaml/v3.0/pa.schema.yaml Show resolved Hide resolved
@swapnilbhalgat swapnilbhalgat marked this pull request as ready for review September 20, 2024 01:53
@swapnilbhalgat swapnilbhalgat requested review from a team as code owners September 20, 2024 01:53
@swapnilbhalgat swapnilbhalgat enabled auto-merge (squash) September 20, 2024 01:58
@swapnilbhalgat swapnilbhalgat merged commit 47a6c25 into master Sep 20, 2024
4 checks passed
@swapnilbhalgat swapnilbhalgat deleted the users/sbhalgat/serializeLayout branch September 20, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joem-msft joem-msft joem-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swapnilbhalgat @joem-msft