run dll before yaml validation tests

microsoft · abaskk-msft · Jul 8, 2024 · Jun 26, 2024 · Jun 27, 2024 · Jun 27, 2024
commit d39f50cf28643f6c1d8fae3c468416d05cf1919d
@@ -40,12 +40,15 @@ jobs:
       run: ./build ci
       if: ${{ runner.os != 'Windows' }}
 
-    - name: Test - YamlValidator
-      run: dotnet bin/Debug/YamlValidator.Tests/YamlValidator.Tests.dll
+    - name: Test - Persistence
+      run: dotnet bin/Debug/Persistence.Tests/Persistence.Tests.dll
 
     - name: Test - PAModel
       run: dotnet bin/Debug/PAModelTests/PAModelTests.dll
 
+    - name: Test - YamlValidator
+      run: dotnet bin/Debug/YamlValidator.Tests/YamlValidator.Tests.dll
+
     - name: Test - Persistence.Tests Yaml Files (ubuntu & macos)
       run: ./scripts/PersistenceValidate.sh
       if: ${{ runner.os != 'Windows' }}
@@ -54,9 +57,6 @@ jobs:
       run: ./scripts/PersistenceValidate.ps1
       if: ${{ runner.os == 'Windows' }}
 
-    - name: Test - Persistence
-      run: dotnet bin/Debug/Persistence.Tests/Persistence.Tests.dll
-
     - name: Restore workloads for samples
       run: dotnet workload restore samples/MauiMsApp/MauiMsApp.csproj
 

diff --git a/samples/MSAppGenerator/ExampleGenerator.cs b/samples/MSAppGenerator/ExampleGenerator.cs
            {
                foreach (var control in controls)
                {
                    childList.Add(_controlFactory.Create(control + childList.Count.ToString(), template: control,
                       properties: new()
                   ));
                }
diff --git a/samples/pptx2msapp/PptxConverter.cs b/samples/pptx2msapp/PptxConverter.cs

 namespace pptx2msapp;

 internal class PptxConverter(IMsappArchiveFactory MsappArchiveFactory, IControlFactory ControlFactory) : IDisposable
 {
    private IMsappArchive? _msappArchive;
    private bool _isDisposed;
                if (run.RunProperties != null)
                {
                    if (run.RunProperties.Bold != null)
                        text.Append($"font-weight: {(run.RunProperties.Bold.Value ? "bold" : "normal")}; ");
                    if (run.RunProperties.FontSize != null)
                        text.Append($"font-size: {run.RunProperties.FontSize.Value / 100}pt; ");
                }
                text.Append($"'>");

            }
        );

        _msappArchive!.App!.Screens.Last().Children.Add(image);
    }

    #region Helpers
diff --git a/samples/pptx2msapp/Program.cs b/samples/pptx2msapp/Program.cs

 namespace pptx2msapp;

 internal class Program
 {
    public static IServiceProvider ServiceProvider { get; private set; }
	{
	foreach (var control in controls)
	{
	childList.Add(_controlFactory.Create(control + childList.Count.ToString(), template: control,
Check warning on line 107 in samples/MSAppGenerator/ExampleGenerator.cs GitHub Actions / build (windows-latest) `The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'ExampleGenerator.GenerateApp(int, IList<string>)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)` Check warning on line 107 in samples/MSAppGenerator/ExampleGenerator.cs GitHub Actions / build (windows-latest) `The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'ExampleGenerator.GenerateApp(int, IList<string>)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)` Check warning on line 107 in samples/MSAppGenerator/ExampleGenerator.cs GitHub Actions / build (windows-latest) `The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'ExampleGenerator.GenerateApp(int, IList<string>)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)`
	properties: new()
	));
	}

	namespace pptx2msapp;

	internal class PptxConverter(IMsappArchiveFactory MsappArchiveFactory, IControlFactory ControlFactory) : IDisposable
Check warning on line 13 in samples/pptx2msapp/PptxConverter.cs GitHub Actions / build (windows-latest) `Type 'PptxConverter' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)`
	{
	private IMsappArchive? _msappArchive;
	private bool _isDisposed;
	if (run.RunProperties != null)
	{
	if (run.RunProperties.Bold != null)
	text.Append($"font-weight: {(run.RunProperties.Bold.Value ? "bold" : "normal")}; ");
Check warning on line 128 in samples/pptx2msapp/PptxConverter.cs GitHub Actions / build (windows-latest) `The behavior of 'StringBuilder.Append(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'PptxConverter.ConvertShape(string, TextBody, ShapeProperties, IList<Control>)' with a call to 'StringBuilder.Append(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)` Check warning on line 128 in samples/pptx2msapp/PptxConverter.cs GitHub Actions / build (windows-latest) `The behavior of 'StringBuilder.Append(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'PptxConverter.ConvertShape(string, TextBody, ShapeProperties, IList<Control>)' with a call to 'StringBuilder.Append(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)`
	if (run.RunProperties.FontSize != null)
	text.Append($"font-size: {run.RunProperties.FontSize.Value / 100}pt; ");
Check warning on line 130 in samples/pptx2msapp/PptxConverter.cs GitHub Actions / build (windows-latest) `The behavior of 'StringBuilder.Append(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'PptxConverter.ConvertShape(string, TextBody, ShapeProperties, IList<Control>)' with a call to 'StringBuilder.Append(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)`
	}
	text.Append($"'>");

	}
	);

	_msappArchive!.App!.Screens.Last().Children.Add(image);
Check warning on line 177 in samples/pptx2msapp/PptxConverter.cs GitHub Actions / build (windows-latest) `Dereference of a possibly null reference.` Check warning on line 177 in samples/pptx2msapp/PptxConverter.cs GitHub Actions / build (windows-latest) `Dereference of a possibly null reference.`
	}

	#region Helpers

	namespace pptx2msapp;

	internal class Program
Check warning on line 9 in samples/pptx2msapp/Program.cs GitHub Actions / build (windows-latest) `Type 'Program' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)`
	{
	public static IServiceProvider ServiceProvider { get; private set; }