Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Formulas.Tools to netstandard2.0 #684

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

tehcrashxor
Copy link
Member

In commit 1c9b22c back in Dec 2023, all projects in the repo were set to use the same TargetFramework, all sourced from a single shared file.

This accidentally effected the Formulas.Tooling lib, which needs to remain on netstandard2.0 for use in both .NET and .NET Framework versions of PAC CLI.

This PR switches that library back to netstandard2.0, and reverts a few changes since that point for new syntax net8.0 which is not available to netstandard2.0.

@tehcrashxor tehcrashxor requested a review from petrochuk June 28, 2024 00:28
@tehcrashxor tehcrashxor requested review from a team as code owners June 28, 2024 00:28
@tehcrashxor tehcrashxor enabled auto-merge (squash) June 28, 2024 19:39
@tehcrashxor tehcrashxor merged commit e2da260 into master Jun 28, 2024
4 checks passed
@tehcrashxor tehcrashxor deleted the users/tehcrash/2406/revertNetStandardChange branch June 28, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants