-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend MsappArchive APIs #675
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizrael
reviewed
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need to add these methods to the interface? can't we have them exposed as extension methods instead?
petrochuk
previously requested changes
Jun 21, 2024
joem-msft
force-pushed
the
users/joemay/MsappArchive-improvements
branch
3 times, most recently
from
June 22, 2024 02:11
1f22180
to
0ccc194
Compare
tehcrashxor
approved these changes
Jun 24, 2024
joem-msft
force-pushed
the
users/joemay/MsappArchive-improvements
branch
from
June 25, 2024 00:04
0ccc194
to
3418f8c
Compare
joem-msft
force-pushed
the
users/joemay/MsappArchive-improvements
branch
from
June 25, 2024 00:14
3418f8c
to
6525724
Compare
tehcrashxor
approved these changes
Jun 25, 2024
swapnilbhalgat
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves some new APIs used in the DocSvr code into the MsappArchive and IMsappArchive APIs in this repo.
DoesEntryExist
- allows callers to determine whether an entry exists w/o needing to inspect internal canonical dictionary.TryGenerateUniqueEntryPath
- exposes logic for generating a unique entry, in case similar entries already exist. This function is similar to the private methodGetSafeEntryPath
, but this method only has a single responsibility, in order to make it more usable for different scenarios.MsappArchive.TryMakeSafeForEntryPathSegment
is a new static method that has a single responsibility, allowing it's usage to be composed with other functions depending on the scenario. It is similar to encoding a path segment of a URI. Namely, the char set it allows is anything that could be a valid file name or directory name.GetSafeEntryPath
is modified to use the newTryGenerateUniqueEntryPath
andTryMakeSafeForEntryPathSegment
methods.GetEntry
,GetRequiredEntry
methods were updated to utilize theTryGetEntry
method.Validation: