Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PASopa for modern controls #670

Merged
merged 3 commits into from
Jun 14, 2024
Merged

PASopa for modern controls #670

merged 3 commits into from
Jun 14, 2024

Conversation

marcelbf
Copy link
Contributor

#668

Problem

Certain modern controls used the same template - pcfDataField.

A changed has been made to modern controls. They can now allow individual controls to define that properties should be made available per column in the dataset. That effectively means that each control has the opportunity to modify the pcfDataField template.

The issue was caused when 2 controls would reference the same template - the template name used in the parser was the reference, instead of the specific template for the given control - that would cause a collision.

What is the issue we are attempting to solve?

Solution

Specify the specific template name in the parser, so it can correctly find it in the template store.

Changes

  • Add a new parameter to specify the template name in the template parser.
  • Update the document to call the parser with template name from used Templates.
  • Update the source serializer to retrieve the template name from the file.
  • Added unit test

Validation

  • manual test (app with 2 modern controls)
  • added unit test for this scenario
  • executed all unit tests

marcelbf added 2 commits June 13, 2024 14:10
added unit test to unpack and pack an app with modern controls.
@marcelbf marcelbf requested review from a team as code owners June 14, 2024 00:19
@marcelbf marcelbf requested review from joem-msft and mizrael June 14, 2024 00:20
@marcelbf marcelbf enabled auto-merge (squash) June 14, 2024 03:20
@marcelbf marcelbf merged commit 97a7fef into master Jun 14, 2024
4 checks passed
@marcelbf marcelbf deleted the marcelbf/modern-controls branch June 14, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants