Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabular connectors - initial work #2306

Merged
merged 15 commits into from
Apr 10, 2024
Merged

Tabular connectors - initial work #2306

merged 15 commits into from
Apr 10, 2024

Conversation

LucGenetier
Copy link
Contributor

No description provided.

@LucGenetier LucGenetier changed the title Tabular connectors (WIP) Tabular connectors - initial work Apr 9, 2024
@LucGenetier LucGenetier marked this pull request as ready for review April 9, 2024 14:46
@LucGenetier LucGenetier requested a review from a team as a code owner April 9, 2024 14:46
@LucGenetier LucGenetier enabled auto-merge (squash) April 9, 2024 16:48
@MikeStall
Copy link
Contributor

MikeStall commented Apr 9, 2024 •
edited by LucGenetier
Loading 

    internal ODataParameters(bool count, string filter, string orderby, int top)

can we make these public?

Callers will need to allocate so they can pass to GetItemsAsync

#Resolved

Refers to: src/libraries/Microsoft.PowerFx.Connectors/Obsolete/ODataQueryableTableValue.cs:62 in bf3a280. [](commit_id = bf3a280, deletion_comment = False)

@LucGenetier
Copy link
Contributor Author

LucGenetier commented Apr 9, 2024 •
edited
Loading 

    internal ODataParameters(bool count, string filter, string orderby, int top)

I think this is more than a draft and needs to be improved
This storage is really dirty to my eyes

In reply to: 2045765729

Refers to: src/libraries/Microsoft.PowerFx.Connectors/Obsolete/ODataQueryableTableValue.cs:62 in bf3a280. [](commit_id = bf3a280, deletion_comment = False)

@MikeStall
Copy link
Contributor 

    internal ODataParameters(bool count, string filter, string orderby, int top)

can we fix?
It has to be public in order for a to create it to pass to TabularStorage.GetItemsAsync().

We can totally remove ODataQueryableTableValue if that helps. That's already obsolete, and old legacy hacky.

In reply to: 2045866270

Refers to: src/libraries/Microsoft.PowerFx.Connectors/Obsolete/ODataQueryableTableValue.cs:62 in bf3a280. [](commit_id = bf3a280, deletion_comment = False)

@LucGenetier
Copy link
Contributor Author

LucGenetier commented Apr 10, 2024 •
edited
Loading

Public API changes:
❌CP0001 T:Microsoft.PowerFx.Connectors.ODataQueryableTableValue
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.AddTo(System.Collections.Specialized.NameValueCollection)
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithCount
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithFilter(System.String)
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithOrderby(System.String)
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithTop(System.Int32)
❌CP0007 T:Microsoft.PowerFx.Connectors.ODataParameters #Closed

@LucGenetier
Copy link
Contributor Author

LucGenetier commented Apr 10, 2024 •
edited
Loading

Public API changes:
❌CP0001 T:Microsoft.PowerFx.Connectors.ODataQueryableTableValue
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.AddTo(System.Collections.Specialized.NameValueCollection)
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithCount
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithFilter(System.String)
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithOrderby(System.String)
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithTop(System.Int32)
❌CP0007 T:Microsoft.PowerFx.Connectors.ODataParameters #Closed

@LucGenetier
Copy link
Contributor Author

Public API changes:
❌CP0001 T:Microsoft.PowerFx.Connectors.ODataQueryableTableValue
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.AddTo(System.Collections.Specialized.NameValueCollection)
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithCount
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithFilter(System.String)
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithOrderby(System.String)
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithTop(System.Int32)
❌CP0007 T:Microsoft.PowerFx.Connectors.ODataParameters

@LucGenetier
Copy link
Contributor Author

Public API changes:
❌CP0001 T:Microsoft.PowerFx.Connectors.ODataQueryableTableValue
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.AddTo(System.Collections.Specialized.NameValueCollection)
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithCount
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithFilter(System.String)
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithOrderby(System.String)
❌CP0002 M:Microsoft.PowerFx.Connectors.ODataParameters.WithTop(System.Int32)
❌CP0007 T:Microsoft.PowerFx.Connectors.ODataParameters

MikeStall
MikeStall approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@MikeStall MikeStall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LucGenetier LucGenetier merged commit 6bfd5c3 into main Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeStall MikeStall MikeStall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucGenetier @MikeStall