Change Error Span for "Function X has some invalid arguments" #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function, so it doesn't hide other errors in the formula bar
|
✅ No public API change. |
|
Do not merge, pending test in PA Client |
|
✅ No public API change. |
lesaltzm
added a commit
that referenced
this pull request
Apr 22, 2024
This fixes a nullref that's always been possible in ErrorContainer.HaserrorsInTree Following #2284 it was more common that errors had only a token and not a node. This wasn't handled in this function.
lesaltzm
added a commit
that referenced
this pull request
Apr 22, 2024
This fixes a nullref that's always been possible in ErrorContainer.HaserrorsInTree Following #2284 it was more common that errors had only a token and not a node. This wasn't handled in this function.
lesaltzm
added a commit
that referenced
this pull request
Apr 22, 2024
This fixes a nullref that's always been possible in ErrorContainer.HaserrorsInTree Following #2284 it was more common that errors had only a token and not a node. This wasn't handled in this function.
lesaltzm
added a commit
that referenced
this pull request
Apr 22, 2024
This fixes a nullref that's always been possible in ErrorContainer.HaserrorsInTree Following #2284 it was more common that errors had only a token and not a node. This wasn't handled in this function.
lesaltzm
added a commit
that referenced
this pull request
Apr 25, 2024
This fixes a nullref that's always been possible in ErrorContainer.HaserrorsInTree Following #2284 it was more common that errors had only a token and not a node. This wasn't handled in this function.
lesaltzm
added a commit
that referenced
this pull request
Apr 25, 2024
This fixes a nullref that's always been possible in ErrorContainer.HaserrorsInTree Following #2284 it was more common that errors had only a token and not a node. This wasn't handled in this function.
lesaltzm
added a commit
that referenced
this pull request
Apr 25, 2024
This fixes a nullref that's always been possible in ErrorContainer.HaserrorsInTree Following #2284 it was more common that errors had only a token and not a node. This wasn't handled in this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the error span for "some invalid arguments" to just the head of the call node, so it doesn't hide/distract from other more specific errors in the formula bar