Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't suggest fields that are already specified #2240

Merged
merged 2 commits into from
Mar 5, 2024
Merged

don't suggest fields that are already specified #2240

merged 2 commits into from
Mar 5, 2024

Conversation

jas-valgotar
Copy link
Contributor

Fixes #2126

@jas-valgotar jas-valgotar requested a review from a team as a code owner March 4, 2024 18:17
MikeStall
MikeStall previously approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@MikeStall MikeStall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LucGenetier
Copy link
Contributor

✅ No public API change.

Shpakh-MSFT
Shpakh-MSFT previously approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Shpakh-MSFT Shpakh-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jas-valgotar jas-valgotar enabled auto-merge (squash) March 5, 2024 17:53
@jas-valgotar jas-valgotar force-pushed the jas/do-not-suggest-repeat-field-aggregate branch from fd7022c to 733e764 Compare March 5, 2024 17:53
@jas-valgotar jas-valgotar disabled auto-merge March 5, 2024 18:06
@LucGenetier
Copy link
Contributor

✅ No public API change.

@jas-valgotar jas-valgotar dismissed stale reviews from Shpakh-MSFT and MikeStall via 65ad7b5 March 5, 2024 18:19
@LucGenetier
Copy link
Contributor

✅ No public API change.

@jas-valgotar jas-valgotar merged commit 7af72ad into main Mar 5, 2024
4 checks passed
@jas-valgotar jas-valgotar deleted the jas/do-not-suggest-repeat-field-aggregate branch March 5, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shpakh-MSFT Shpakh-MSFT Shpakh-MSFT left review comments

@MikeStall MikeStall MikeStall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

intellisense: don't suggest fields that are already specified
4 participants
@jas-valgotar @LucGenetier @MikeStall @Shpakh-MSFT