Update logic to determine whether a LookUp call with a reduction formula argument can be delegated #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ula can be delegated
|
✅ No public API change. |
…rs/ianleg/fx_lookup_arg3
…rs/ianleg/fx_lookup_arg3
|
✅ No public API change. |
…rs/ianleg/fx_lookup_arg3
…rs/ianleg/fx_lookup_arg3
|
✅ No public API change. |
|
✅ No public API change. |
…rs/ianleg/fx_lookup_arg3
|
✅ No public API change. |
lesaltzm
reviewed
Mar 4, 2024
src/libraries/Microsoft.PowerFx.Core/Texl/Builtins/FilterDelegationBase.cs
Show resolved
Hide resolved
lesaltzm
reviewed
Mar 4, 2024
lesaltzm
reviewed
Mar 4, 2024
lesaltzm
reviewed
Mar 4, 2024
…rs/ianleg/fx_lookup_arg3
|
✅ No public API change. |
src/libraries/Microsoft.PowerFx.Core/Texl/Builtins/FilterDelegationBase.cs
Outdated
Show resolved
Hide resolved
|
✅ No public API change. |
lesaltzm
approved these changes
Mar 13, 2024
…rs/ianleg/fx_lookup_arg3
|
✅ No public API change. |
ian-legler
added a commit
that referenced
this pull request
Mar 15, 2024
Incorrect logic for determining whether a LookUp Call node could be delegated was added in a previous PR #2065 Updating the logic to ensure proper handling of edge cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the logic to determine whether a LookUp function call with a reduction formula argument is incorrect, purely checking whether the node is marked as NOT delegatable.
This means that most scenarios are marked delegable, but uses of the LookUp function as part of the filter in a delegatable function (e.g. LookUp, Filter, etc.) can lead to incorrect code gen.
Updating the logic to try to determine whether the full function can be delegated, in context.