show warning only on tables . prevents warnign on Table(First(DS))

microsoft · Mar 12, 2024 · 121d1e3 · 121d1e3
1 parent 53aa731
commit 121d1e3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/libraries/Microsoft.PowerFx.Core/Texl/Builtins/Table.cs b/src/libraries/Microsoft.PowerFx.Core/Texl/Builtins/Table.cs
@@ -116,7 +116,7 @@ public override void CheckSemantics(TexlBinding binding, TexlNode[] args, DType[
             {
                 var ads = argTypes[i].AssociatedDataSources?.FirstOrDefault();
 
-                if (ads is IExternalTabularDataSource)
+                if (argTypes[i].IsTableNonObjNull && ads is IExternalTabularDataSource)
                 {
                     errors.EnsureError(DocumentErrorSeverity.Warning, args[i], TexlStrings.ErrTruncatedArgWarning, args[i].ToString(), Name);
                     continue;

diff --git a/src/tests/Microsoft.PowerFx.Core.Tests/TexlTests.cs b/src/tests/Microsoft.PowerFx.Core.Tests/TexlTests.cs
@@ -2475,14 +2475,19 @@ public void TexlFunctionTypeSemanticsTimeValue(string script)
         [InlineData("Table([1,2], If(1/0<2,[3,4]), [5,6])", "*[Value: n]")]
         [InlineData("Table(Sequence(20000))", "*[Value: n]")]
         [InlineData("Table(Filter(T1, b = 5))", "*[a:n, b:n, c:n]")]
-        [InlineData("Table({X:1}, [1, 2, 3])", "*[X:n, Value:n]")]
+        [InlineData("Table({X:1}, [1, 2, 3])", "*[X:n, Value:n]")]
+        [InlineData("Table(First(DS), Last(DS))", "*[Id:n, Name:s, Age:n]")]
+        [InlineData("Table(Last(DS), {count: CountRows(DS)})", "*[Id:n, Name:s, Age:n]")]
         public void TexlFunctionTypeSemanticsTable(string script, string expectedType)
         {
             var symbol = new SymbolTable();
             symbol.AddVariable("T1", new TableType(TestUtils.DT("*[a:n, b:n, c:n]")));
             symbol.AddVariable("T2", new TableType(TestUtils.DT("*[a:n, b:b, c:s]")));
             symbol.AddVariable("T3", new TableType(TestUtils.DT("*[d:n]")));
             symbol.AddVariable("T4", new TableType(TestUtils.DT("*[a:s]")));
+
+            var dataSourceSchema = TestUtils.DT("*[Id:n, Name:s, Age:n]");
+            symbol.AddEntity(new TestDataSource("DS", dataSourceSchema));
 
             Assert.True(DType.TryParse(expectedType, out DType type));
             Assert.True(type.IsValid);