Defer DiaSession's symbol init (it is unused by WinPix (or anyone?)) #6187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python3kgae
approved these changes
Jan 23, 2024
austinkinross
approved these changes
Jan 23, 2024
tex3d
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The init of the dia symbol manager presents an unneccessary performance hit for WinPix. It's quite simple to defer the init, so here we are.
(This dia implementation was originally added specifically for WinPix, but was then superseded by a simpler API. It's entirely possible that there are no other clients of the dia interface at all, but it has been published, so we're probably bound to maintain it.)
(Note that there are other deferment opportunities here, but the larger pending work is to disentangle the dia implementation from that of the new "IDxcPix*" API that WinPix uses, which would obviate deferment altogether, but that's way out of scope for me for now.)