Make clang-format happy #6177
Merged
Make clang-format happy #6177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build is failing due to clang-format modifying these lines. I've changed them to what clang-format wants even though it's a bit odd, and updated the CMake script to make the error message more clear when this type of failure occurs.
|
I'm not sure if this is due to a change in clang-format, so we'll see if the bots fail this now. @Keenuts, @cassiebeckley and I are all getting local build failures, but I think we're all working with a tip-of-tree build of clang-format, and maybe we don't want to try to keep up with that if that's the cause... |
llvm-beanz
approved these changes
Jan 22, 2024
hekota
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build is failing due to clang-format modifying these lines. I've changed them to what clang-format wants even though it's a bit odd, and updated the CMake script to make the error message more clear when this type of failure occurs.