Add extra type null checking to prevent AV #4538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pow2clk
reviewed
Jul 1, 2022
|
❌ Build DirectXShaderCompiler 1.0.1819 failed (commit 312ea271a1 by @bob80905) |
pow2clk
reviewed
Jul 6, 2022
tools/clang/test/HLSLFileCheck/hlsl/semantics/legacy/D3D9_effect_ps_6_0Tex2D.hlsl
Outdated
Show resolved
Hide resolved
|
❌ Build DirectXShaderCompiler 1.0.1821 failed (commit 2bb7c55987 by @bob80905) |
|
❌ Build DirectXShaderCompiler 1.0.1833 failed (commit bc12669c77 by @bob80905) |
Notes: If resource arg is used, StripFunctionParameter will fail, causing validation failure. Test modifiations are not intended to be kept. Testing would have to be different, ultimately.
|
❌ Build DirectXShaderCompiler 1.0.1845 failed (commit bd91df379f by @bob80905) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unsupported semantic types, grabbing the semantic type would result in a nullptr. There was never a check to see if the type returned was null, and so this PR will prevent AV from happening by skipping the appropriate statements when the semantic returned is null and reporting the issue to the user.
This PR should address #3377