[spirv] support non-int type SV_DispatchThreadId #3481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the SPIR-V spec, we cannot use types other than a vector with 3 integer element for `%gl_GlobalInvocationID`. However, HLSL `SV_DispatchThreadId` stage variable allows other types. This difference results in a SPIR-V validation error when we use float for `SV_DispatchThreadId`. This commit fixes the issue. Fixes microsoft#3443
|
Hello @jaebaek , I just thought that I should bring it to your notice that we have a pending change #3043 that is still under review on DXIL side to do more comprehensive type checking for SV semantics. As part of that, we intend to disallow non-integer types for SV_DispatchThreadID. I would also let @tex3d comment on this just in case he has something to add here. Thanks! |
|
✅ Build DirectXShaderCompiler 1.0.4345 completed (commit e9d22d04c8 by @jaebaek) |
|
Yes, float was not really supposed to be a valid type to be used for SV_DispatchThreadID. When the other change is merged, it may simply make this case dead code and make the test in this PR fail, since it would no longer be legal HLSL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the SPIR-V spec, we cannot use types other than a vector
with 3 integer element for
%gl_GlobalInvocationID. However, HLSLSV_DispatchThreadIdstage variable allows other types. Thisdifference results in a SPIR-V validation error when we use float for
SV_DispatchThreadId. This commit fixes the issue.Fixes #3443