address feedback, no tests yet

microsoft · Jan 13, 2025 · 3c4b566 · 3c4b566
1 parent 7dc1d0d
commit 3c4b566
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/lib/DxilContainer/DxcContainerBuilder.cpp b/lib/DxilContainer/DxcContainerBuilder.cpp
@@ -104,10 +104,11 @@ HRESULT STDMETHODCALLTYPE DxcContainerBuilder::RemovePart(UINT32 fourCC) {
 
 HRESULT STDMETHODCALLTYPE
 DxcContainerBuilder::SerializeContainer(IDxcOperationResult **ppResult) {
-  DxcThreadMalloc TM(m_pMalloc);
   if (ppResult == nullptr)
     return E_INVALIDARG;
 
+  DxcThreadMalloc TM(m_pMalloc);
+
   try {
     // Allocate memory for new dxil container.
     uint32_t ContainerSize = ComputeContainerSize();
@@ -165,11 +166,9 @@ DxcContainerBuilder::SerializeContainer(IDxcOperationResult **ppResult) {
     }
 
     // Add Hash.
-    LPVOID PTR = pResult->GetBufferPointer();
-    if (!IsDxilContainerLike(PTR, pResult->GetBufferSize()))
-      return E_FAIL;
-
-    HashAndUpdate((DxilContainerHeader *)PTR);
+    if (SUCCEEDED(valHR))
+      HashAndUpdate(IsDxilContainerLike(pResult->GetBufferPointer(),
+                                        pResult->GetBufferSize()));
 
     IFT(DxcResult::Create(
         valHR, DXC_OUT_OBJECT,