sema: gracefully reject 0-sized IO patch (#6138)

InputPatch and OutputPatch array size must be greater than 0. Before
this patch we emitted a validation error, which told the user this was a
compiler issue.

Fixes #3734

---------

Signed-off-by: Nathan Gauër <[email protected]>

tools/clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -7884,6 +7884,10 @@ def err_hlsl_node_record_object : Error<
    "object %0 may not appear in a node record">;
 def err_hlsl_array_disallowed : Error<
    "%select{entry parameter|declaration}1 of type %0 may not be an array">;
+def err_hlsl_inputpatch_size: Error<
+   "InputPatch element count must be greater than 0">;
+def err_hlsl_outputpatch_size: Error<
+   "OutputPatch element count must be greater than 0">;
 def note_hlsl_node_array : Note<"'%0' cannot be used as an array; did you mean '%0Array'?">;
 // HLSL Change Ends
 

tools/clang/lib/Sema/SemaHLSL.cpp

@@ -15138,6 +15138,17 @@ void DiagnoseMeshEntry(Sema &S, FunctionDecl *FD, llvm::StringRef StageName) {
   return;
 }
 
+void DiagnoseDomainEntry(Sema &S, FunctionDecl *FD, llvm::StringRef StageName) {
+  for (const auto *param : FD->params()) {
+    if (!hlsl::IsHLSLOutputPatchType(param->getType()))
+      continue;
+    if (hlsl::GetHLSLInputPatchCount(param->getType()) > 0)
+      continue;
+    S.Diags.Report(param->getLocation(), diag::err_hlsl_outputpatch_size);
+  }
+  return;
+}
+
 void DiagnoseHullEntry(Sema &S, FunctionDecl *FD, llvm::StringRef StageName) {
   HLSLPatchConstantFuncAttr *Attr = FD->getAttr<HLSLPatchConstantFuncAttr>();
   if (!Attr)
@@ -15147,6 +15158,13 @@ void DiagnoseHullEntry(Sema &S, FunctionDecl *FD, llvm::StringRef StageName) {
     S.Diags.Report(FD->getLocation(), diag::err_hlsl_missing_attr)
         << StageName << "outputtopology";
 
+  for (const auto *param : FD->params()) {
+    if (!hlsl::IsHLSLInputPatchType(param->getType()))
+      continue;
+    if (hlsl::GetHLSLInputPatchCount(param->getType()) > 0)
+      continue;
+    S.Diags.Report(param->getLocation(), diag::err_hlsl_inputpatch_size);
+  }
   return;
 }
 
@@ -15573,7 +15591,6 @@ void DiagnoseEntry(Sema &S, FunctionDecl *FD) {
   switch (Stage) {
   case DXIL::ShaderKind::Pixel:
   case DXIL::ShaderKind::Vertex:
-  case DXIL::ShaderKind::Domain:
   case DXIL::ShaderKind::Library:
   case DXIL::ShaderKind::Invalid:
     return;
@@ -15583,6 +15600,8 @@ void DiagnoseEntry(Sema &S, FunctionDecl *FD) {
   case DXIL::ShaderKind::Mesh: {
     return DiagnoseMeshEntry(S, FD, StageName);
   }
+  case DXIL::ShaderKind::Domain:
+    return DiagnoseDomainEntry(S, FD, StageName);
   case DXIL::ShaderKind::Hull: {
     return DiagnoseHullEntry(S, FD, StageName);
   }

tools/clang/test/SemaHLSL/ds-error-outputpatch-size.hlsl

@@ -0,0 +1,11 @@
+// RUN: %dxc -T ds_6_0 -E main -verify %s
+// RUN: %dxc -T ds_6_0 -E main -verify %s -spirv
+
+struct ControlPoint {
+  float position : MY_BOOL;
+};
+
+ControlPoint main(const OutputPatch<ControlPoint, 0> patch) { // expected-error {{OutputPatch element count must be greater than 0}}
+  return patch[0];
+}
+

tools/clang/test/SemaHLSL/hs-error-inputpatch-size.hlsl

@@ -0,0 +1,23 @@
+// RUN: %dxc -T hs_6_0 -E main -verify %s
+// RUN: %dxc -T hs_6_0 -E main -verify %s -spirv
+
+struct ControlPoint {
+  float position : MY_BOOL;
+};
+
+struct PatchData {
+    float edge [3] : SV_TessFactor;
+    float inside : SV_InsideTessFactor;
+};
+
+PatchData HullConst () { return (PatchData)0; }
+
+[domain("tri")]
+[partitioning("fractional_odd")]
+[outputtopology("triangle_cw")]
+[patchconstantfunc("HullConst")]
+[outputcontrolpoints(3)]
+ControlPoint main(InputPatch<ControlPoint, 0> v, // expected-error {{InputPatch element count must be greater than 0}}
+                  uint id : SV_OutputControlPointID) {
+  return v[id];
+}