Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure R directory is present before attempting to update package mirror config #4332

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

jonnyry
Copy link
Collaborator

@jonnyry jonnyry commented Feb 6, 2025

cc @tamirkamara

Small change to the vm_config.ps1 script to check if the C:\ProgramFiles\R directory is present before attempting to update the package mirror config.

Addresses the bug found here:

https://github.com/microsoft/AzureTRE/actions/runs/13177381524/job/36780564434#step:3:1255

Message: "VM has reported a user failure when processing extension 'windowsvmc5a1-vmextension'. Please correct the error and try again. (publisher 'Microsoft.Compute' and type 'CustomScriptExtension'). Error code: '2'. Error message: 'Command execution finished, but failed because it returned a non-zero exit code of: '1'. The command had an error output of: 'Get-ChildItem : Cannot find path 'C:\\Program Files\\R' because it does not exist.\r\nAt C:\\azuredata\\configure.ps1:56 char:14\r\n+ $RVersions = Get-ChildItem -Path $RBasePath -Directory | Where-Object ...\r\n+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...' For more information, check the instance view by executing Get-AzVmssVm or Get-AzVm (https://aka.ms/GetAzVm). These commands can be executed using CloudShell (https://aka.ms/CloudShell)'. Detailed error: ''. More information on troubleshooting is available at https://aka.ms/VMExtensionCSEWindowsTroubleshoot." │ Activity Id: "" │ │ --- │ │ API Response: │ │ ----[start]---- │ *** │ "startTime": "2025-02-06T11:43:43.4017185+00:00", │ "endTime": "2025-02-06T11:46:38.7652198+00:00", │ "status": "Failed", │ "error": *** │ "code": "VMExtensionProvisioningError", │ "message": "VM has reported a user failure when processing extension 'windowsvmc5a1-vmextension'. Please correct the error and try again. (publisher 'Microsoft.Compute' and type 'CustomScriptExtension'). Error code: '2'. Error message: 'Command execution finished, but failed because it returned a non-zero exit code of: '1'. The command had an error output of: 'Get-ChildItem : Cannot find path 'C:\\Program Files\\R' because it does not exist.\r\nAt C:\\azuredata\\configure.ps1:56 char:14\r\n+ $RVersions = Get-ChildItem -Path $RBasePath -Directory | Where-Object ...\r\n+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...' For more information, check the instance view by executing Get-AzVmssVm or Get-AzVm (https://aka.ms/GetAzVm). These commands can be executed using CloudShell (https://aka.ms/CloudShell)'. Detailed error: ''. More information on troubleshooting is available at https://aka.ms/VMExtensionCSEWindowsTroubleshoot." │ ***, │ "name": "8ea931c6-681e-4642-b76

Copy link

github-actions bot commented Feb 6, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 6830f96.

♻️ This comment has been updated with latest results.

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamirkamara
Copy link
Collaborator

/test-extended

Copy link

github-actions bot commented Feb 6, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13180732951 (with refid b9c3c396)

(in response to this comment from @tamirkamara)

@marrobi marrobi enabled auto-merge (squash) February 6, 2025 15:51
@marrobi
Copy link
Member

marrobi commented Feb 6, 2025

/test-force-approve

Tests failed on transient Azure issue we should log, but I have tested this locally and works, (the issue blocked me deploying windows VMs from main)

Copy link

github-actions bot commented Feb 6, 2025

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit d780153)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member

marrobi commented Feb 6, 2025

/test-force-approve

Copy link

github-actions bot commented Feb 6, 2025

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 6830f96)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit a73cf2f into microsoft:main Feb 6, 2025
12 checks passed
@jonnyry jonnyry deleted the jr/upstream-main/146-r-script-fix branch February 6, 2025 17:22
@marrobi
Copy link
Member

marrobi commented Feb 7, 2025

/test-destroy-env

Copy link

github-actions bot commented Feb 7, 2025

Destroying PR test environment (RG: rg-treb9c3c396)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13209416178)

Copy link

github-actions bot commented Feb 7, 2025

PR test environment destroy complete (RG: rg-treb9c3c396)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants