Fix workspace menu and connect button issues #3821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…howing when shouldn't
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 4ec521c. ♻️ This comment has been updated with latest results. |
|
@damoodamoo @jjgriff93 if have any ideas what's caused the workspace menu issues would love to know, but this seems to fix. Thanks, |
jjgriff93
approved these changes
Jan 5, 2024
|
Looks good - and no idea to be honest |
|
/test-force-approve ui only |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 4ec521c) (in response to this comment from @marrobi) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3819 #3820
This pull request fixes two issues in the code:
The workspace menu was not working correctly.
The connect button was showing even when there was no URI available.
These issues have been resolved by updating the code in the affected files.