Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional airlock tests and perf and logging tweaks #3732

Closed
wants to merge 2 commits into from

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Oct 5, 2023

What is being addressed

I made these changes to do some airlock load testing as per #3725 and others. We may not decide to merge this PR, but wanted to start a discussion, especially around requirement for email addresses to use the airlock.

How is this addressed

  • Configure a longer timeout on gunicorn and set to 5 workers
  • Remove unessecary print of cosmos partition key
  • Enable console logging handler in DEBUG.
  • Configure airlock to work without email addresses configured. Not sure why these are mandatory, notifications might be picked up y systems other than email. Allows service principal to be used for testing.
  • Configure auto app reg creation for e2e tests if AUTO_WORKSPACE_APP_REGISTRATION is configured.
  • Added perf test to airlock.

@marrobi marrobi enabled auto-merge (squash) October 5, 2023 15:24
@marrobi marrobi requested a review from tamirkamara October 5, 2023 15:25
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 54cc01c.

♻️ This comment has been updated with latest results.

@marrobi marrobi marked this pull request as draft November 7, 2023 17:21
auto-merge was automatically disabled November 7, 2023 17:21

Pull request was converted to draft

@marrobi marrobi closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant