Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/build.py: Add "path" entry to index.json. #910

Merged

Conversation

dpgeorge
Copy link
Member

This points to the package's base directory of the within the micropython-lib directory structure.

@dpgeorge dpgeorge requested a review from mattytrentini August 20, 2024 06:34
@dpgeorge
Copy link
Member Author

@mattytrentini hopefully this is what's needed for mim.

This points to the package's base directory of the within the
micropython-lib directory structure.

Signed-off-by: Damien George <[email protected]>
@dpgeorge dpgeorge force-pushed the tools-build-add-package-path-to-index branch from 9c1e3c3 to 910af18 Compare August 20, 2024 06:35
@HowManyOliversAreThere
Copy link

@dpgeorge This looks like it should do the trick, I'll try this out to generate the json and insert it into mim to sanity check the path but should be great.

For reference, mim currently uses https://wb5lsudgvpt4f4j4pxomg5z3ui0dcgjt.lambda-url.ap-southeast-2.on.aws/ for the current proof of concept, where we've injected the url value into the existing json object by trawling the repo. Will be much nicer to use the official json directly!

HowManyOliversAreThere added a commit to HowManyOliversAreThere/mim that referenced this pull request Aug 20, 2024
Utilise official parameter in the JSON as implemented in micropython/micropython-lib#910
@HowManyOliversAreThere
Copy link

Added support for this parameter into mim and generated the json from this repo to test against and found it to be working as expected (from the spot checks I did), including things like finding the aioble README that was missed with my naive implementation. Thanks @dpgeorge !

@dpgeorge dpgeorge merged commit 910af18 into micropython:master Aug 22, 2024
4 checks passed
@dpgeorge dpgeorge deleted the tools-build-add-package-path-to-index branch August 22, 2024 02:56
@dpgeorge
Copy link
Member Author

@HowManyOliversAreThere thanks for testing, great that it works! Now merged.

@mattytrentini
Copy link
Contributor

@dpgeorge when will this appear at https://micropython.org/pi/v2/index.json? I had thought it would update the build machine overnight but I'm seeing v1...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants