Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use addResource for mp config files #628

Closed
wants to merge 1 commit into from
Closed

Use addResource for mp config files #628

wants to merge 1 commit into from

Conversation

benjamin-confino
Copy link
Contributor

This resolves #626

No changes to smallrye were needed to pass with these changes.

@eclipse-microprofile-bot
Copy link
Contributor

Can one of the admins verify this patch?

@Azquelt
Copy link
Member

Azquelt commented Jun 4, 2024

@eclipse-microprofile-bot test this please

@Azquelt
Copy link
Member

Azquelt commented Jun 4, 2024

This issue was incorrect, the spec does make this additional requirement:

For convenience, you may also place your microprofile-config.properties in the root META-INF folder, if you wish to keep both documents in the same directory. This is in addition to the default locations defined by MicroProfile Config.

@Azquelt Azquelt closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azquelt Azquelt Azquelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TCKs put microprofile-config.properties in the wrong location
3 participants
@benjamin-confino @eclipse-microprofile-bot @Azquelt