Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.adoc #223

Closed
wants to merge 5 commits into from
Closed

Update README.adoc #223

wants to merge 5 commits into from

Conversation

rsoika
Copy link
Contributor

@rsoika rsoika commented Jan 11, 2020

replaced inline code fragments with italic style to avoid broken layout on microprofile.io

See #222

replaced inline code fragments with italic style to avoid broken layout on microprofile.io
Seems that my 'signed-off-by' footer was missing ....

Signed-off-by: rsoika <[email protected]>
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rsoika. Three things:

1/ You need to sign the ECA and the commit - https://accounts.eclipse.org/legal/eca/validation/23377
2/ Can you squash the changes into one commit, please?
3/ Did you verify that this will fix the issue? I tried to build the site locally and even without this change, it renders correctly so I am just wondering whether you have a similar architecture to what the site actually uses.

Thanks again for the contribution.

@xstefank
Copy link
Member

xstefank commented Apr 9, 2020

@rsoika we can't merge the PR without signed ECA. Can you take a look at this, please?

@rsoika
Copy link
Contributor Author

rsoika commented Apr 9, 2020

Yes I have forgotten to sign it. What should I do? Can I create a new one?

@xstefank
Copy link
Member

xstefank commented Apr 9, 2020

No, just sign the commit and force push this branch. This is what I usually do.

Of course if you prefer, create a new PR :).

@rsoika
Copy link
Contributor Author

rsoika commented Apr 9, 2020

Sorry I do not know how to do this. I was already on this page https://accounts.eclipse.org/legal/eca/validation/23377 and hit the 'revalidate' - but this seems not what is expected :-/

@xstefank
Copy link
Member

xstefank commented Apr 9, 2020

@rsoika no worries. What you need to do is to log in/configure your local git with the same email that you've signed the ECA. Then just do git commit -s ...-am "message" etc. The -s will sign the commit with your current configured email address. All commits in your PRs should be signed like this (but I think the check runs only for the latest one). And then force push this PR branch, or just do the same changes in different branch with a new commit (with -s) and a new PR. Hope this helps.

@rsoika
Copy link
Contributor Author

rsoika commented Apr 9, 2020

I am really sorry for this chaos. I can't help myself.
Please check this again: #249

You can see that I have a sign-off message in my commit. I do not understand the problem. I have done a similar change in the past to the config project here: microprofile/microprofile-config#506

@xstefank
Copy link
Member

xstefank commented Apr 9, 2020

@rsoika no worries, we all had to learn this once. Don't worry about this PR. If #249 is the same as this one, than just close this and let's move to #249 since that is already signed.

@rsoika rsoika closed this Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants