-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.adoc #223
Update README.adoc #223
Conversation
replaced inline code fragments with italic style to avoid broken layout on microprofile.io
Seems that my 'signed-off-by' footer was missing .... Signed-off-by: rsoika <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rsoika. Three things:
1/ You need to sign the ECA and the commit - https://accounts.eclipse.org/legal/eca/validation/23377
2/ Can you squash the changes into one commit, please?
3/ Did you verify that this will fix the issue? I tried to build the site locally and even without this change, it renders correctly so I am just wondering whether you have a similar architecture to what the site actually uses.
Thanks again for the contribution.
@rsoika we can't merge the PR without signed ECA. Can you take a look at this, please? |
Yes I have forgotten to sign it. What should I do? Can I create a new one? |
No, just sign the commit and force push this branch. This is what I usually do. Of course if you prefer, create a new PR :). |
Sorry I do not know how to do this. I was already on this page https://accounts.eclipse.org/legal/eca/validation/23377 and hit the 'revalidate' - but this seems not what is expected :-/ |
@rsoika no worries. What you need to do is to log in/configure your local git with the same email that you've signed the ECA. Then just do |
minor changes #223 Signed-off-by: rsoika <[email protected]>
Signed-off-by: Ralph Soika <[email protected]>
I am really sorry for this chaos. I can't help myself. You can see that I have a sign-off message in my commit. I do not understand the problem. I have done a similar change in the past to the config project here: microprofile/microprofile-config#506 |
replaced inline code fragments with italic style to avoid broken layout on microprofile.io
See #222