Fixes a logic bug in Pyramidal storage #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2023 18:31
Also lots of cleanup and addition of JavaDoc.
nicost
changed the title
|
You found it--Awesome! |
|
If you bump the version in the POM this will automatically propagate up to the ivy file in micro-manager |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a logic bug encountered in Micro-Magellan. The code in
populateNewResolutionLevel(called when increasing the resolution level), callsaddToLowResStoragewith the row and column index of the previous level rather than the top level (as that code expected before this PR). This would remarkably work most of the time, but there were clearly times this would break. SincepopulateNewResolutionLevelhad no way of knowing the original row and column, I changed the functionsaddToLowResStorageanddownsampleto work with the row and column of the previous level rather than that of the top level image. This fixes the behavior observed in Micro-Magellan.Most (all?) other changes are cosmetic and will help to make this code more maintainable in the future.