Replace run_somd.sh with Pydantic configuration class #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This completes pretty much all the changes suggested in this comment: #11 (comment). All tests pass, although a3fe/tests/test_sys_prep_configuration.py::test_config_dump_and_load is flaky - it seems to fail when run as part of the full test suite. We should fix this before merging into main.
@Roy-Haolin-Du please could you take a look? Feel free to merge in if you're happy and fix any mistakes I've made. Pushing quickly to avoid any duplication of effort with you also working on it. Thanks!